BTCP-Rebase icon indicating copy to clipboard operation
BTCP-Rebase copied to clipboard

[mempool] MemPoolRemovalReason for CTxMemPool::removeWithAnchor

Open ch4ot1c opened this issue 6 years ago • 0 comments

See: https://github.com/zcash/zcash/blob/333b9a0d0b0db2ada9f106ac73cef22a77914ec7/src/txmempool.cpp#L209 https://github.com/zcash/zcash/blob/333b9a0d0b0db2ada9f106ac73cef22a77914ec7/src/txmempool.cpp#L125

CTxMemPool::remove has been replaced by removeRecursive. Additionally, the MemPoolRemovalReason from Bitcoin does not include a case to handle CTxMemPool::removeWithAnchor:

If a block is disconnected from the tip, and the root changed, we must invalidate transactions from the mempool which spend from that root -- almost as though they were spending coinbases which are no longer valid to spend due to coinbase maturity.

Perhaps this calls for a REANCHORED MempoolRemovalReason, since it is a slightly different case than the existing CONFLICT option ("Removed for conflict with in-block transaction").


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

ch4ot1c avatar Jul 21 '18 20:07 ch4ot1c