BTCP-Rebase icon indicating copy to clipboard operation
BTCP-Rebase copied to clipboard

Add license header entries for "The Zcash developers" as changes are rebased

Open str4d opened this issue 6 years ago • 1 comments

One task that's been pending on the Zcash to-do list is to go through and update the license header entries of the various Bitcoin Core files we added code to (zcash/zcash#2887). Given that you are rebasing the Zcash changes (and in particular, are not preserving the original commits), and it would likely be a lot more work to pull in our eventual license header updates, it would be a good idea to add the following header line as you go (since all the code you pull in will be non-Bitcoin Core code, it should be obvious where to apply it):

Copyright (c) 2016-2018 The Zcash developers

At a minimum, this notification must be preserved in COPYING, contrib/debian/copyright, and src/clientversion.h, as well as any Zcash-specific files it's already in, in order to satisfy the MIT license.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

str4d avatar Apr 25 '18 23:04 str4d

Thanks for dropping by - any omission of headers currently is unintentional (they are already there in files that were unique to zcash for example https://github.com/BTCPrivate/BTCP-Rebase/blob/master/src/asyncrpcoperation.cpp). We'll make best efforts to add as we go along as per your suggestion and then do a final go through towards the end of the process to patch anything we've missed.

BTW - if you think you might find any of the work we're doing here useful - we're eager to help or upstream changes - just let us know.

P.S. only reason commit history wasn't preserved is because it made a bit more sense to go module by module rather than commit by commit - and we're trying to restructure a bit to more cleanly separate the zk related stuff in the consensus layer to the extent it can be. If there's an easy way to get the commit history in - even if just the logs - lmk? Would definitely be useful to have.

jc23424 avatar Apr 26 '18 00:04 jc23424