boinc icon indicating copy to clipboard operation
boinc copied to clipboard

Add an opportunity to check if docker/docker compose is installed on …

Open Tanya1515 opened this issue 1 year ago • 6 comments

Pull request for issue 5617

Tanya1515 avatar May 07 '24 15:05 Tanya1515

@Tanya1515, thank you for your PR. Before we can start review, test and discuss this approach, please fix the falling CI flows. Thank you in advance.

AenBleidd avatar May 07 '24 21:05 AenBleidd

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes are missing coverage. Please review.

Project coverage is 10.52%. Comparing base (5251053) to head (4e6a460). Report is 20 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5618      +/-   ##
============================================
- Coverage     10.54%   10.52%   -0.02%     
  Complexity     1068     1068              
============================================
  Files           279      279              
  Lines         35869    35915      +46     
  Branches       8409     8427      +18     
============================================
- Hits           3781     3779       -2     
- Misses        31694    31742      +48     
  Partials        394      394              
Files Coverage Δ
db/boinc_db_types.h 0.00% <ø> (ø)
lib/cc_config.h 0.00% <ø> (ø)
sched/plan_class_spec.h 0.00% <ø> (ø)
sched/sched_types.cpp 0.00% <0.00%> (ø)
lib/cc_config.cpp 0.00% <0.00%> (ø)
lib/hostinfo.cpp 0.00% <0.00%> (ø)
sched/sched_customize.cpp 0.00% <0.00%> (ø)
sched/plan_class_spec.cpp 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

codecov[bot] avatar May 08 '24 10:05 codecov[bot]

@AenBleidd I have improved my code (all misprints and whitespaces are fixed). However, CI flows are failed on test covering. All files, that i have modified, don't have test covering at all. What should i do with the error?

Thank you in advance.

Tanya1515 avatar May 08 '24 12:05 Tanya1515

@Tanya1515, code coverage is not important and can be ignored. I'll take a look at the code at the beginning of the next week. Thank you for your PR!

AenBleidd avatar May 08 '24 12:05 AenBleidd

@AenBleidd, have you taken look at the code/my issue[https://github.com/BOINC/boinc/issues/5617]?

Thank you in advance.

Tanya1515 avatar Jun 03 '24 10:06 Tanya1515

Hello @Tanya1515, sorry for the delay. We were busy releasing a new version of BOINC. I plan to review and test your PR during next couple of weeks.

AenBleidd avatar Jun 03 '24 10:06 AenBleidd

Closing this in favor of #5757 that contains a better approach of docker detection.

AenBleidd avatar Aug 14 '24 13:08 AenBleidd