boinc
boinc copied to clipboard
Add an opportunity to check if docker/docker compose is installed on …
@Tanya1515, thank you for your PR. Before we can start review, test and discuss this approach, please fix the falling CI flows. Thank you in advance.
Codecov Report
Attention: Patch coverage is 0% with 49 lines in your changes are missing coverage. Please review.
Project coverage is 10.52%. Comparing base (
5251053) to head (4e6a460). Report is 20 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #5618 +/- ##
============================================
- Coverage 10.54% 10.52% -0.02%
Complexity 1068 1068
============================================
Files 279 279
Lines 35869 35915 +46
Branches 8409 8427 +18
============================================
- Hits 3781 3779 -2
- Misses 31694 31742 +48
Partials 394 394
| Files | Coverage Δ | |
|---|---|---|
| db/boinc_db_types.h | 0.00% <ø> (ø) |
|
| lib/cc_config.h | 0.00% <ø> (ø) |
|
| sched/plan_class_spec.h | 0.00% <ø> (ø) |
|
| sched/sched_types.cpp | 0.00% <0.00%> (ø) |
|
| lib/cc_config.cpp | 0.00% <0.00%> (ø) |
|
| lib/hostinfo.cpp | 0.00% <0.00%> (ø) |
|
| sched/sched_customize.cpp | 0.00% <0.00%> (ø) |
|
| sched/plan_class_spec.cpp | 0.00% <0.00%> (ø) |
@AenBleidd I have improved my code (all misprints and whitespaces are fixed). However, CI flows are failed on test covering. All files, that i have modified, don't have test covering at all. What should i do with the error?
Thank you in advance.
@Tanya1515, code coverage is not important and can be ignored. I'll take a look at the code at the beginning of the next week. Thank you for your PR!
@AenBleidd, have you taken look at the code/my issue[https://github.com/BOINC/boinc/issues/5617]?
Thank you in advance.
Hello @Tanya1515, sorry for the delay. We were busy releasing a new version of BOINC. I plan to review and test your PR during next couple of weeks.
Closing this in favor of #5757 that contains a better approach of docker detection.