stage_file_native.cpp issues

Open davidpanderson opened this issue 2 years ago • 3 comments

Problems with this:

It generates compile warnings (unused vars, shadowed vars)
It has no comments or documentation
the PR says it's a library function, but it has main() so it can't be used as a library function

Should this be removed? It's redundant with the PHP script stage_file

Oct 08 '23 19:10 davidpanderson

This was added here: https://github.com/BOINC/boinc/issues/4733

I believe, it's still useful to have it, so maybe we should just fix the issues and the documentation?

Oct 08 '23 19:10 AenBleidd

It's C++ code that does the same thing as existing PHP code. If it's significantly faster maybe it's useful, but it's not clear that it is faster.

Oct 08 '23 20:10 davidpanderson

I remember there was a reason for that. Just don't recall which exactly. I'll try to find out and we can consider how to proceed with that later.

Oct 08 '23 21:10 AenBleidd