Atlas icon indicating copy to clipboard operation
Atlas copied to clipboard

Thread-Safety Issues

Open carlbennett opened this issue 4 years ago • 3 comments

This issue was created to track thread-safety issues in the early stages of the development of Atlas.

carlbennett avatar Dec 01 '20 03:12 carlbennett

Looping over the gameAds list isn't thread-safe. This may cause problems if a game is added or removed while this loop is processing. This safety issue is a systemic problem within Atlas however, and I understand if this is out of scope; I would just add a lock{} around it.

Originally posted by @carlbennett in https://github.com/BNETDocs/Atlas/pull/13#discussion_r532174135

carlbennett avatar Dec 01 '20 03:12 carlbennett

Maybe I can help out. Are you worried about adding locks? If not, I can go through and analyze the multithreaded stuff so it's all thread-safe with locks.

x3haloed avatar Nov 27 '21 01:11 x3haloed

@x3haloed If you want to fork the project and assist by creating a pull request with your work, it would be reviewed and likely welcomed.

carlbennett avatar Dec 30 '21 04:12 carlbennett