vue-ssr-carousel
vue-ssr-carousel copied to clipboard
Published
20 hours ago •
BKWLD
BKWLD
aria-current
Level access audit for COR flagged this as a high priority issue. Basically they are saying that aria-disabled shouldn't be how we set the active slide dot state. They suggest aria-current.
I tested this simple change locally, and things seem to be fine, but I wanted to show you in case you think of some other reasons why we shouldn't do this.
One ramification is that if other sites update the carousel package, they will need to update any custom styling that hooks into the disabled attribute...
From level access:
![codesandbox[bot] avatar](https://avatars.githubusercontent.com/in/206332?v=4 "Published by a pub.dev verified publisher"){kind=small}
Passing run #118 ↗︎
 0 |
 18 |
 0 |
 0 |
 0 |
Details:
| trying out aria-current for active slide | |||
| Project: vue-ssr-carousel | Commit: 4cf56b00f6 |
||
| Status: Passed | Duration: 01:15 💡 | ||
| Started: Apr 10, 2024 8:03 PM | Ended: Apr 10, 2024 8:04 PM | ||
Review all test suite changes for PR #144 ↗︎
![cypress[bot] avatar](https://avatars.githubusercontent.com/in/9078?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for vue-ssr-carousel ready!
| Name | Link |
|---|---|
| Latest commit | 4cf56b00f692242c5a15a8b2330254dfabafdd81 |
| Latest deploy log | https://app.netlify.com/sites/vue-ssr-carousel/deploys/6616f0dde76161000824d3f6 |
| Deploy Preview | https://deploy-preview-144--vue-ssr-carousel.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}