LifeCycleAssessment_Toolkit icon indicating copy to clipboard operation
LifeCycleAssessment_Toolkit copied to clipboard

Add EPiC Datasets

Open michaelhoehn opened this issue 4 years ago • 13 comments
trafficstars

NOTE: Depends on

Issues addressed by this PR

Closes #244

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/LifeCycleAssessment_Toolkit/%23244-EPiC%20Database/EpicDatabase.gh?csf=1&web=1&e=45wgpn

Changelog

Additional comments

michaelhoehn avatar Aug 30 '21 23:08 michaelhoehn

Any way that we'd be able to grab the density too? Not sure if it's in the raw dataset: image

kayleighhoude avatar Sep 16 '21 13:09 kayleighhoude

Outside of the phase issue everything looks great! Super happy to have this dataset, please lmk when this is ready for review again! @michaelhoehn

kayleighhoude avatar Sep 16 '21 13:09 kayleighhoude

Please add additional phases (A2, A3) understand from our conversation that this was an Excel Toolkit issue

Done!

Any way that we'd be able to grab the density too? Not sure if it's in the raw dataset:

This metric isn't in their formatted xml database, but it is in each of the documentation material linked in the database. Since that will take hours to scrape I suggest we move ahead with the dataset as is and get some additional resource to add the density fragments at a later stage.

Adding the actual Density fragment is a trival matter, but scraping is the time consuming bit that can be added in the next feature sprint.

If that's acceptable I believe this PR is ready for approval.

michaelhoehn avatar Dec 01 '21 21:12 michaelhoehn

@BHoMBot check compliance please

michaelhoehn avatar Dec 01 '21 21:12 michaelhoehn

@michaelhoehn to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

bhombot-ci[bot] avatar Dec 01 '21 21:12 bhombot-ci[bot]

@BHoMBot check compliance

michaelhoehn avatar Dec 02 '21 12:12 michaelhoehn

@michaelhoehn to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

bhombot-ci[bot] avatar Dec 02 '21 12:12 bhombot-ci[bot]

@BHoMBot check core @BHoMBot check installer @BHoMBot check null handling @BHoMBot check serialisation @BHoMBot check versioning

michaelhoehn avatar Dec 02 '21 12:12 michaelhoehn

@michaelhoehn to confirm, the following checks are now queued:

  • core
  • installer
  • serialisation
  • versioning

bhombot-ci[bot] avatar Dec 02 '21 12:12 bhombot-ci[bot]

@BHoMBot check null-handling

michaelhoehn avatar Dec 02 '21 12:12 michaelhoehn

@michaelhoehn to confirm, the following checks are now queued:

  • null-handling

There are 8 requests in the queue ahead of you.

bhombot-ci[bot] avatar Dec 02 '21 12:12 bhombot-ci[bot]

@kayleighhoude how are we looking for a rereview on this one?

michaelhoehn avatar Jan 24 '22 21:01 michaelhoehn

@michaelhoehn went to review this and I think because of the Reflection oM not existing anymore it won't build, any ideas on how to repair?

kayleighhoude avatar Feb 05 '22 01:02 kayleighhoude

This has been rebased and is ready for review and merge @kayleighhoude @enarhi @shivanierambaran prior to Jan. 11th

FYI @FraserGreenroyd as part of the PR closer initiative 🦖

michaelhoehn avatar Jan 03 '23 14:01 michaelhoehn

@BHoMBot check compliance

michaelhoehn avatar Jan 04 '23 17:01 michaelhoehn

@michaelhoehn to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 11 requests in the queue ahead of you.

bhombot-ci[bot] avatar Jan 04 '23 17:01 bhombot-ci[bot]

@BHoMBot check required

michaelhoehn avatar Jan 04 '23 17:01 michaelhoehn

@michaelhoehn to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

bhombot-ci[bot] avatar Jan 04 '23 17:01 bhombot-ci[bot]

@BHoMBot check ready-to-merge

FraserGreenroyd avatar Jan 04 '23 17:01 FraserGreenroyd

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 5 requests in the queue ahead of you.

bhombot-ci[bot] avatar Jan 04 '23 17:01 bhombot-ci[bot]

@BHoMBot check required

michaelhoehn avatar Jan 04 '23 20:01 michaelhoehn

@michaelhoehn to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

bhombot-ci[bot] avatar Jan 04 '23 20:01 bhombot-ci[bot]

@BHoMBot check compliance

michaelhoehn avatar Jan 04 '23 22:01 michaelhoehn

@michaelhoehn to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

bhombot-ci[bot] avatar Jan 04 '23 22:01 bhombot-ci[bot]

@BHoMBot check ready-to-merge

michaelhoehn avatar Jan 04 '23 23:01 michaelhoehn

@michaelhoehn to confirm, the following actions are now queued:

  • check ready-to-merge

bhombot-ci[bot] avatar Jan 04 '23 23:01 bhombot-ci[bot]