ETABS_Toolkit icon indicating copy to clipboard operation
ETABS_Toolkit copied to clipboard

Turn all assembly names from lower to capital letters.

Open GCRA101 opened this issue 6 months ago • 20 comments

Issues addressed by this PR

Closes #496

Renamed all assembly files using capital letters for both debug and release.

GCRA101 avatar May 21 '25 14:05 GCRA101

@BHoMBot check installer

peterjamesnugent avatar May 21 '25 14:05 peterjamesnugent

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

bhombot-ci[bot] avatar May 21 '25 14:05 bhombot-ci[bot]

Peter, thanks for the review. You can find the comments incorporated in the latest commit: https://github.com/BHoM/ETABS_Toolkit/commit/2a54294c1aeb370311671107a0f703a76233e6ff

GCRA101 avatar May 21 '25 15:05 GCRA101

@BHoMBot check installer

peterjamesnugent avatar May 21 '25 16:05 peterjamesnugent

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

bhombot-ci[bot] avatar May 21 '25 16:05 bhombot-ci[bot]

@BHoMBot check ready-to-merge

GCRA101 avatar May 28 '25 14:05 GCRA101

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

bhombot-ci[bot] avatar May 28 '25 14:05 bhombot-ci[bot]

@peterjamesnugent, @Chrisshort92, I've rebased this branch on our develop branch to pick up the updates we've made to the source code over these months. Tested the branch quickly in grasshopper and all works as expected. I think we're ready to merge ;)

GCRA101 avatar Oct 28 '25 11:10 GCRA101

@BHoMBot check installer

GCRA101 avatar Nov 04 '25 10:11 GCRA101

@GCRA101 to confirm, the following actions are now queued:

  • check installer

There are 85 requests in the queue ahead of you.

bhombot-ci[bot] avatar Nov 04 '25 10:11 bhombot-ci[bot]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

bhombot-ci[bot] avatar Nov 04 '25 10:11 bhombot-ci[bot]

@BHoMBot check installer

michaelhoehn avatar Nov 04 '25 15:11 michaelhoehn

@michaelhoehn to confirm, the following actions are now queued:

  • check installer

There are 2 requests in the queue ahead of you.

bhombot-ci[bot] avatar Nov 04 '25 15:11 bhombot-ci[bot]

@BHoMBot this is a DevOps instruction. Run a force check on: installer

michaelhoehn avatar Nov 04 '25 16:11 michaelhoehn

@michaelhoehn I'm sorry, but I am not authorised to take that instruction from you.

bhombot-ci[bot] avatar Nov 04 '25 16:11 bhombot-ci[bot]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

bhombot-ci[bot] avatar Nov 04 '25 16:11 bhombot-ci[bot]

@BHoMBot this is a DevOps instruction. Run a force check on: installer

adecler avatar Nov 04 '25 16:11 adecler

@adecler I am now running force checks on the checks requested. These will be queued and actioned ASAP.

bhombot-ci[bot] avatar Nov 04 '25 16:11 bhombot-ci[bot]

@adecler I have provided force checks to the checks requested.

bhombot-ci[bot] avatar Nov 04 '25 16:11 bhombot-ci[bot]

Started testing this using the standard testing scripts. Tested on ETABS Version 22.7.0 using Rhino 7.

The adapter is successfully connected, however it fails when pushing objects giving the following error message. This could be related to missing graphics related DLL's? image

Also, it is noted test scripts need to be updated with ETABS settings when using ETABS adapter (as per the recent changes made in BHoM 8.3). Currently, made a workaround in the tested script (Structures - Create, Read and Update Elements).

samuelbasimalla avatar Nov 08 '25 15:11 samuelbasimalla