ETABS_Toolkit
ETABS_Toolkit copied to clipboard
Allow Multiple Logic Requests
Issues addressed by this PR
Closes #465
ETABS Toolkit now can allow to pull objects from ETABS based on FilterRequests, SelectedRequest and multiple LogicalRequests.
Test files
Grasshopper File https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23474-AllowMultipleLogicRequests/TestScript.gh?csf=1&web=1&e=93kD0Q ETABS File https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23474-AllowMultipleLogicRequests/Test%20ETABS%20Model.EDB?csf=1&web=1&e=IRUEie
Changelog
- Added Read Method for FitlerRequests
- Added Read Method for LogicalRequests (And, Or and Not)
- Added Dynamic Comparer class allowing to compare IBHoMObjects based on ad-hoc criteria
@Chrisshort92 , @peterjamesnugent , @IsakNaslundBh,
I've had the chance to finish the pull request for issue #465.
Also for this one, a pull request to be reviewed in the next sprint moving forward BHoM 7.4, not now ;)
Thanks guys! ;)
@BHoMBot Check required
@Chrisshort92 to confirm, the following actions are now queued:
- check
code-compliance - check
documentation-compliance - check
project-compliance - check
core - check
null-handling - check
serialisation - check
versioning - check
installer
There are 39 requests in the queue ahead of you.
@Chrisshort92 , I've gone through the code compliance checks above and I've modified the code as per following commit 655b110e1e7603fbc53df5a40c28d7a463434b84 Turned the DynamicComparer from a private class within the _Read.cs file into a public class within the Types namespace.
@BHoMBot Check required
@GCRA101 to confirm, the following actions are now queued:
- check
code-compliance - check
documentation-compliance - check
project-compliance - check
core - check
null-handling - check
serialisation - check
versioning - check
installer
There are 85 requests in the queue ahead of you.
The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.
The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.
The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.
The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.
@BHoMBot check compliance @BHoMBot check ready-to-merge
@peterjamesnugent to confirm, the following actions are now queued:
- check
code-compliance - check
documentation-compliance - check
project-compliance - check
branch-compliance - check
dataset-compliance - check
copyright-compliance - check
ready-to-merge
There are 19 requests in the queue ahead of you.
The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.
The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.
The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.
@peterjamesnugent, added copyright header to DynamicComparer in latest commit. 9b081de06fd93e990711bee8fd65c5e748cb3113
@BHoMBot check required
@GCRA101 to confirm, the following actions are now queued:
- check
code-compliance - check
documentation-compliance - check
project-compliance - check
core - check
null-handling - check
serialisation - check
versioning - check
installer
@BHoMBot check copyright-compliance
@GCRA101 to confirm, the following actions are now queued:
- check
copyright-compliance
There are 28 requests in the queue ahead of you.
@BHoMBot check required
@GCRA101 to confirm, the following actions are now queued:
- check
code-compliance - check
documentation-compliance - check
project-compliance - check
core - check
null-handling - check
serialisation - check
versioning - check
installer
There are 14 requests in the queue ahead of you.
Please be advised that the check with reference 32166477143 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 1318 additional annotations waiting, made up of 1318 errors and 0 warnings.
@BHoMBot check installer
@Chrisshort92 to confirm, the following actions are now queued:
- check
installer