BHoM_Engine icon indicating copy to clipboard operation
BHoM_Engine copied to clipboard
verified publisher icon BHoM

Geometry_Engine: Merge and write a proper test file for Flip and Reverse methods

Open pawelbaran opened this issue 6 years ago • 4 comments

As in the header, these two could probably be merged. General test file is on the server, to be revised and updated.

As discussed in #1060, word Reverse is preferred over Flip.

pawelbaran avatar May 08 '19 14:05 pawelbaran

@pawelbaran But do we actually need method reverse? It takes only lines and vectors. For lines there is identical method in Flip. And for Vectors we can use multiplication operator (*-1).

LMarkowski avatar May 09 '19 10:05 LMarkowski

That's exactly what I mean - we need to clean it up and put under one method. So regarding your cases:

  1. Leave only one for Line
  2. I would leave the Reverse/Flip for Vector only in case it could be called by an interface method

pawelbaran avatar May 09 '19 11:05 pawelbaran

@pawelbaran As per wiki, can you remove this item from the "Review in Progress" column of the SCRUM BOARD please?

epignatelli avatar Sep 11 '19 10:09 epignatelli

@LMarkowski could you please parse through the whole Engine to make sure we do not have duplicates in discipline-specific projects?

pawelbaran avatar Sep 23 '19 08:09 pawelbaran