BHoM_Engine icon indicating copy to clipboard operation
BHoM_Engine copied to clipboard

Matter_Engine: Add material mapping methods

Open IsakNaslundBh opened this issue 3 years ago • 8 comments
trafficstars

Issues addressed by this PR

Closes #2900

  • Add method for mapping properties from a set of pre-defined material maps on a set of Materials
  • Add methods for mapping onto MaterialCompositiona and Takeoffs
  • Add methods for getting mapped Takeoffs and Compositions from a list of IElementM

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/ElafUY8_5_dOs1UN37qQ1kQBFOo2qUahCMBTEbp2g7uEag?e=rRgCke

Changelog

Additional comments

IsakNaslundBh avatar Oct 25 '22 13:10 IsakNaslundBh

@BHoMBot check compliance

IsakNaslundBh avatar Oct 25 '22 13:10 IsakNaslundBh

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

bhombot-ci[bot] avatar Oct 25 '22 13:10 bhombot-ci[bot]

@BHoMBot check compliance @BHoMBot check null-handling

IsakNaslundBh avatar Oct 27 '22 09:10 IsakNaslundBh

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check null-handling

bhombot-ci[bot] avatar Oct 27 '22 09:10 bhombot-ci[bot]

@BHoMBot check compliance @BHoMBot check null-handling

IsakNaslundBh avatar Oct 27 '22 10:10 IsakNaslundBh

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check null-handling

bhombot-ci[bot] avatar Oct 27 '22 10:10 bhombot-ci[bot]

@michaelhoehn this should be good to go for testing now. Happy to have a quick call if needed.

Will add UTs to this PR once the approach taken in the PR has been approved and agreed.

IsakNaslundBh avatar Oct 27 '22 10:10 IsakNaslundBh

Please see the comment here https://github.com/BHoM/LifeCycleAssessment_Toolkit/pull/288#pullrequestreview-1199895883

michaelhoehn avatar Nov 30 '22 19:11 michaelhoehn

Branch naming inconsistencies have required me to fork this branch for compliance purposes FYI @FraserGreenroyd

michaelhoehn avatar Dec 01 '22 18:12 michaelhoehn

@BHoMBot check core

michaelhoehn avatar Dec 01 '22 19:12 michaelhoehn

@michaelhoehn to confirm, the following actions are now queued:

  • check core

bhombot-ci[bot] avatar Dec 01 '22 19:12 bhombot-ci[bot]

@BHoMBot check required

michaelhoehn avatar Dec 01 '22 19:12 michaelhoehn

@michaelhoehn to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

bhombot-ci[bot] avatar Dec 01 '22 19:12 bhombot-ci[bot]

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

bhombot-ci[bot] avatar Dec 01 '22 19:12 bhombot-ci[bot]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

bhombot-ci[bot] avatar Dec 01 '22 20:12 bhombot-ci[bot]

@BHoMBot check documentation-compliance

michaelhoehn avatar Dec 01 '22 20:12 michaelhoehn

@michaelhoehn to confirm, the following actions are now queued:

  • check documentation-compliance

bhombot-ci[bot] avatar Dec 01 '22 20:12 bhombot-ci[bot]

@BHoMBot check required

michaelhoehn avatar Dec 01 '22 20:12 michaelhoehn

@michaelhoehn to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

bhombot-ci[bot] avatar Dec 01 '22 20:12 bhombot-ci[bot]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

bhombot-ci[bot] avatar Dec 01 '22 20:12 bhombot-ci[bot]

@BHoMBot check unit-tests @BHoMBot check copyright-compliance @BHoMBot check dataset-compliance

FraserGreenroyd avatar Dec 01 '22 22:12 FraserGreenroyd

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests
  • check copyright-compliance
  • check dataset-compliance

bhombot-ci[bot] avatar Dec 01 '22 22:12 bhombot-ci[bot]

@BHoMBot check ready-to-merge

FraserGreenroyd avatar Dec 01 '22 22:12 FraserGreenroyd

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 8 requests in the queue ahead of you.

bhombot-ci[bot] avatar Dec 01 '22 22:12 bhombot-ci[bot]