BHoM_Engine
BHoM_Engine copied to clipboard
Structure_Engine: Clean up ToBeRemoved methods
NOTE: Depends on
Issues addressed by this PR
Closes #2736
Test files
Changelog
Additional comments
@BHoMBot check installer
Running to check more toolkits affected by the change
@IsakNaslundBh to confirm, the following checks are now queued:
installer
@BHoMBot check installer
Running to check more toolkits affected by the change
@IsakNaslundBh to confirm, the following checks are now queued:
installer
@BHoMBot check installer
@IsakNaslundBh to confirm, the following checks are now queued:
installer
@BHoMBot check versioning
@IsakNaslundBh to confirm, the following checks are now queued:
versioning
@BHoMBot check compliance
@IsakNaslundBh to confirm, the following checks are now queued:
code-compliancedocumentation-complianceproject-compliancebranch-compliancedataset-compliancecopyright-compliance
There are 5 requests in the queue ahead of you.
@BHoMBot check required
@IsakNaslundBh to confirm, the following checks are now queued:
code-compliancedocumentation-complianceproject-compliancecorenull-handlingserialisationversioninginstaller
The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.
The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.
@IsakNaslundBh what's the sitrep on this PR then? 😄
@BHoMBot check versioning
@IsakNaslundBh to confirm, the following actions are now queued:
- check
versioning
@BHoMBot check versioning
@IsakNaslundBh to confirm, the following actions are now queued:
- check
versioning
@BHoMBot check compliance
@IsakNaslundBh to confirm, the following actions are now queued:
- check
code-compliance - check
documentation-compliance - check
project-compliance - check
branch-compliance - check
dataset-compliance - check
copyright-compliance
There are 7 requests in the queue ahead of you.
@BHoMBot check core @BHoMBot check null-handling @BHoMBot check serialisation @BHoMBot check unit-tests
@IsakNaslundBh to confirm, the following actions are now queued:
- check
core - check
null-handling - check
serialisation - check
unit-tests
There are 5 requests in the queue ahead of you.
@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Robot_Toolkit
I Have reviewed the failing UnitTest, which is due to changes of now defaulting orientation of nodes to null rather than world XY.
This change can be deemed fine, why the UnitTest safely can be updated. WIll do this and push to this PR.
@BHoMBot check unit-tests
@IsakNaslundBh to confirm, the following actions are now queued:
- check
unit-tests
@BHoMBot check required
@IsakNaslundBh to confirm, the following actions are now queued:
- check
code-compliance - check
documentation-compliance - check
project-compliance - check
core - check
null-handling - check
serialisation - check
versioning - check
installer
There are 33 requests in the queue ahead of you.
@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance