BHoM_Engine icon indicating copy to clipboard operation
BHoM_Engine copied to clipboard

Structure_Engine: Clean up ToBeRemoved methods

Open IsakNaslundBh opened this issue 3 years ago • 15 comments
trafficstars

NOTE: Depends on

Issues addressed by this PR

Closes #2736

Test files

Changelog

Additional comments

IsakNaslundBh avatar Jan 20 '22 08:01 IsakNaslundBh

@BHoMBot check installer

Running to check more toolkits affected by the change

IsakNaslundBh avatar Jan 24 '22 07:01 IsakNaslundBh

@IsakNaslundBh to confirm, the following checks are now queued:

  • installer

bhombot-ci[bot] avatar Jan 24 '22 07:01 bhombot-ci[bot]

@BHoMBot check installer

Running to check more toolkits affected by the change

IsakNaslundBh avatar Jan 24 '22 09:01 IsakNaslundBh

@IsakNaslundBh to confirm, the following checks are now queued:

  • installer

bhombot-ci[bot] avatar Jan 24 '22 09:01 bhombot-ci[bot]

@BHoMBot check installer

IsakNaslundBh avatar Jan 24 '22 09:01 IsakNaslundBh

@IsakNaslundBh to confirm, the following checks are now queued:

  • installer

bhombot-ci[bot] avatar Jan 24 '22 09:01 bhombot-ci[bot]

@BHoMBot check versioning

IsakNaslundBh avatar Jan 24 '22 14:01 IsakNaslundBh

@IsakNaslundBh to confirm, the following checks are now queued:

  • versioning

bhombot-ci[bot] avatar Jan 24 '22 14:01 bhombot-ci[bot]

@BHoMBot check compliance

IsakNaslundBh avatar Jan 24 '22 15:01 IsakNaslundBh

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

There are 5 requests in the queue ahead of you.

bhombot-ci[bot] avatar Jan 24 '22 15:01 bhombot-ci[bot]

@BHoMBot check required

IsakNaslundBh avatar Jan 24 '22 15:01 IsakNaslundBh

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

bhombot-ci[bot] avatar Jan 24 '22 15:01 bhombot-ci[bot]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

bhombot-ci[bot] avatar Jan 24 '22 15:01 bhombot-ci[bot]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

bhombot-ci[bot] avatar Jan 24 '22 15:01 bhombot-ci[bot]

@IsakNaslundBh what's the sitrep on this PR then? 😄

FraserGreenroyd avatar Nov 24 '22 21:11 FraserGreenroyd

@BHoMBot check versioning

IsakNaslundBh avatar Jan 05 '23 12:01 IsakNaslundBh

@IsakNaslundBh to confirm, the following actions are now queued:

  • check versioning

bhombot-ci[bot] avatar Jan 05 '23 12:01 bhombot-ci[bot]

@BHoMBot check versioning

IsakNaslundBh avatar Jan 05 '23 13:01 IsakNaslundBh

@IsakNaslundBh to confirm, the following actions are now queued:

  • check versioning

bhombot-ci[bot] avatar Jan 05 '23 13:01 bhombot-ci[bot]

@BHoMBot check compliance

IsakNaslundBh avatar Jan 05 '23 13:01 IsakNaslundBh

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 7 requests in the queue ahead of you.

bhombot-ci[bot] avatar Jan 05 '23 13:01 bhombot-ci[bot]

@BHoMBot check core @BHoMBot check null-handling @BHoMBot check serialisation @BHoMBot check unit-tests

IsakNaslundBh avatar Jan 05 '23 13:01 IsakNaslundBh

@IsakNaslundBh to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check unit-tests

There are 5 requests in the queue ahead of you.

bhombot-ci[bot] avatar Jan 05 '23 13:01 bhombot-ci[bot]

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Robot_Toolkit

bhombot-ci[bot] avatar Jan 05 '23 13:01 bhombot-ci[bot]

I Have reviewed the failing UnitTest, which is due to changes of now defaulting orientation of nodes to null rather than world XY.

This change can be deemed fine, why the UnitTest safely can be updated. WIll do this and push to this PR.

IsakNaslundBh avatar Jan 05 '23 14:01 IsakNaslundBh

@BHoMBot check unit-tests

IsakNaslundBh avatar Jan 05 '23 14:01 IsakNaslundBh

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

bhombot-ci[bot] avatar Jan 05 '23 14:01 bhombot-ci[bot]

@BHoMBot check required

IsakNaslundBh avatar Jan 06 '23 11:01 IsakNaslundBh

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 33 requests in the queue ahead of you.

bhombot-ci[bot] avatar Jan 06 '23 11:01 bhombot-ci[bot]

@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance

IsakNaslundBh avatar Jan 06 '23 13:01 IsakNaslundBh