Physical_Engine: Added associated Engine methods for 3D reinforcement representation

[peterjamesnugent]

trafficstars

NOTE: Depends on

https://github.com/BHoM/BHoM/pull/1286

Issues addressed by this PR

Closes https://github.com/BHoM/BHoM/issues/1282

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM/Physical_oM/%231282-AddReinforcement3DRepresentation.gh?csf=1&web=1&e=VqcrUR

Changelog

• Added constructor for Reinforcement method which verifies the IShapeCode is compliant with BS 8666:2020
• Added methods to calculate SchedulingRadius, HookDiameter, GeneralEndProjection and LinksEndProjection based on BS 8666:2020 Table 2#
• Added Centreline method to produce a centreline for the IShapeCode provided

Additional comments

@pawelbaran and @IsakNaslundBh this is a WIP but I wanted to get something up to review before it goes too far - happy to discuss the approach if needed.

[peterjamesnugent]

@BHoMBot check compliance

[peterjamesnugent]

@BHoMBot check compliance

[bhombot-ci[bot]]

@peterjamesnugent to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• branch-compliance
• dataset-compliance
• copyright-compliance

There are 58 requests in the queue ahead of you.

[peterjamesnugent]

@IsakNaslundBh - the three checks are:

• Discontinuities: Zero discontinuities between start and end points
• Length check: <1% difference between calculated length (based on BS 8666 which is not precise) compared against the drawn length
• Dimensions: Dimensions match those input in to the object (against centreline())

Three confirmed correct and ready to merge ((Discontinuities ✔️ , Length ✔️ , dimensions match ✔️ ):

• [ ] Shape Code 00
• [ ] Shape Code 11
• [ ] Shape Code 12
• [ ] Shape Code 13
• [ ] Shape Code 21
• [ ] Shape Code 22
• [ ] Shape Code 23
• [ ] Shape Code 31
• [ ] Shape Code 32
• [ ] Shape Code 33
• [ ] Shape Code 41
• [ ] Shape Code 44
• [ ] Shape Code 47
• [ ] Shape Code 48 (length is 3.43% but I believe that's because the radius is deliverable large 10d and the calculation is simple)
• [ ] Shape Code 51 (there is a discontinuity where the bar overlaps in the Z plane)
• [ ] Shape Code 52 (there is a discontinuity where the bar overlaps in the Z plane)
• [ ] Shape Code 63 (there is a discontinuity where the bar overlaps in the Z plane)
• [ ] Shape Code 64 (there is a discontinuity where the bar overlaps in the Z plane)
• [ ] Shape Code 67 (the dimensions in Rhino are slightly off (by a diameter vertically and two diameters horizontally)
• [ ] Shape Code 75
• [ ] Shape Code 77
• [ ] Shape Code 98 (just within 1%)

Minor difference in dimensions (10s of mm) but proposed to merge (Discontinuities ✔️ , Length ✔️ , dimensions match ❌):

• [ ] Shape Code 14
• [ ] Shape Code 15
• [ ] Shape Code 25
• [ ] Shape Code 27
• [ ] Shape Code 28
• [ ] Shape Code 34 (bottom of the visualisations)
• [ ] Shape Code 35
• [ ] Shape Code 36

Not implemented (2/3: Discontinuities ❌ , Length ❌ , dimensions match ❌) - @pawelbaran these can be the ones we give attention tomorrow.

• [ ] Shape Code 24 (bottom left arc is not correct and shown as discontinuity)
• [x] Shape Code 26 (bottom left arc is not correct and shown as discontinuity) .
• [ ] Shape Code 29 (angled section is 100s mm out)
• [x] Shape Code 46 (1.16% difference in length and difference in dimensions)
• [ ] Shape Code 56 (angled section is 100s mm out)

Shape Code 35 has a similar shape as 24/26 (an angled segment between two horizontal segments, so could try to reuse the code for 35 on 24/26).

[peterjamesnugent]

@BHoMBot check required

[bhombot-ci[bot]]

@peterjamesnugent to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 8 requests in the queue ahead of you.

[bhombot-ci[bot]]

@peterjamesnugent just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

[bhombot-ci[bot]]

@peterjamesnugent just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

[bhombot-ci[bot]]

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci[bot]]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[peterjamesnugent]

@BHoMBot check required

[bhombot-ci[bot]]

@peterjamesnugent to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[peterjamesnugent]

@BHoMBot check required

[bhombot-ci[bot]]

@peterjamesnugent to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[FraserGreenroyd]

@BHoMBot check unit-tests

[bhombot-ci[bot]]

@FraserGreenroyd to confirm, the following actions are now queued:

• check unit-tests

There are 9 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check copyright-compliance @BHoMBot check dataset-compliance

[bhombot-ci[bot]]

@FraserGreenroyd to confirm, the following actions are now queued:

• check copyright-compliance
• check dataset-compliance

[peterjamesnugent]

@BHoMBot check dataset-compliance @BHoMBot check copyright-compliance

[bhombot-ci[bot]]

@peterjamesnugent to confirm, the following actions are now queued:

• check dataset-compliance
• check copyright-compliance

There are 2 requests in the queue ahead of you.

[bhombot-ci[bot]]

The check copyright-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

@BHoMBot check installer

[bhombot-ci[bot]]

@FraserGreenroyd to confirm, the following actions are now queued:

• check installer

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning

[bhombot-ci[bot]]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci[bot]]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge