BHoM_Engine icon indicating copy to clipboard operation
BHoM_Engine copied to clipboard

Geometry_Engine: Null handling

Open rolyhudson opened this issue 4 years ago • 4 comments
trafficstars

NOTE: Depends on

Issues addressed by this PR

Closes #2487

Test files

Changelog

Additional comments

rolyhudson avatar Jun 14 '21 10:06 rolyhudson

@BHoMBot check null-handling

rolyhudson avatar Jun 14 '21 10:06 rolyhudson

@rolyhudson to confirm, the following checks are now queued:

  • null-handling

bhombot-ci[bot] avatar Jun 14 '21 10:06 bhombot-ci[bot]

First attempt at diagramming what is going on with this PR in its current state. Is this insane? Would be good to get a wider consensus on the approach @peterjamesnugent @IsakNaslundBh @FraserGreenroyd @al-fisher. Screenshot 2021-06-28 121550

rolyhudson avatar Jun 28 '21 11:06 rolyhudson

@rolyhudson the diagram looks great- I think it aligns with what we discussed. The challenge is to either make the method generic enough that it can just accept an IGeometry and loop through as you've illustrated with the deep checks etc. or just having IsNull methods for the various objects in the Geometry_oM.

The only thing it doesn't capture is how the messaging is propagated and how much detail that we want to feed back up the chain. Last time we concluded that nested methods shouldn't be a problem because the null will get picked up early, with the deep check at least so I guess there's a decision to be made on how much you want to feedback to the user that it's useful.

peterjamesnugent avatar Jul 06 '21 11:07 peterjamesnugent

This PR has gone stale per our guidelines and following discussion with @IsakNaslundBh it has been decided that this PR would not be suitable given the conflicts, and changes to the Geometry Engine since this PR has been raised. Due to the introduction of check-null-handling it is also difficult to make the situation worse going forward, so although this PR aimed to make things better, we will tackle it as smaller and more discrete tasks going forward. Thanks for the help though @rolyhudson 😄

FraserGreenroyd avatar Jan 04 '23 14:01 FraserGreenroyd