WildStacker icon indicating copy to clipboard operation
WildStacker copied to clipboard

Published 20 hours ago • verified publisher icon BG-Software-LLC

Memory leak

Open Xayanix opened this issue 1 year ago • 14 comments

Minecraft's Version

1.20

Plugin's Version

2023.3

Describe the bug

image

To Reproduce

Server dies after few hours cause of OOM

Additional Information

No response

Xayanix avatar Feb 10 '24 15:02 Xayanix

What version of spigot do you use? Give me the exact output of /version

OmerBenGera avatar Feb 11 '24 04:02 OmerBenGera

2023.3-b36

Xayanix avatar Feb 11 '24 10:02 Xayanix

image

Xayanix avatar Feb 11 '24 10:02 Xayanix

It's full of SpawnCause.SPAWNER

Xayanix avatar Feb 11 '24 16:02 Xayanix

When mob spawner spawns entity, and u remove it via entity.remove() then it stays in ur cache causing memory leak

Xayanix avatar Feb 11 '24 17:02 Xayanix

when I updated wildstacker, I also noticed an increase in memory, I haven't figured out the cause yet, but wildstacker was one of the plugins I updated recently

plugin: WildStacker-2023.3-b42.jar server: version git-Pufferfish-47 (MC: 1.20.4)

SrMonsterYT avatar Apr 05 '24 11:04 SrMonsterYT

Check out latest dev build, let me know if it is better

OmerBenGera avatar Apr 05 '24 13:04 OmerBenGera

Check out latest dev build, let me know if it is better

for me it seems to have increased the leakage even more

SrMonsterYT avatar Apr 06 '24 11:04 SrMonsterYT

@OmerBenGera

there is still memory leakage

spark: https://spark.lucko.me/ulh2wRYUeg

spark heapsummary: https://spark.lucko.me/gla6pQD7In

version plugin: WildStacker-2023.3-b45.jar

SrMonsterYT avatar Apr 06 '24 21:04 SrMonsterYT

@OmerBenGera

there is still memory leakage

spark: https://spark.lucko.me/ulh2wRYUeg

spark heapsummary: https://spark.lucko.me/gla6pQD7In

version plugin: WildStacker-2023.3-b45.jar

@OmerBenGera I've added more information above, what do you recommend I go back to version 35 and wait for you to correct it?

SrMonsterYT avatar Apr 10 '24 11:04 SrMonsterYT

@OmerBenGera help pls

SrMonsterYT avatar Apr 13 '24 20:04 SrMonsterYT

@OmerBenGera there is still memory leakage spark: https://spark.lucko.me/ulh2wRYUeg spark heapsummary: https://spark.lucko.me/gla6pQD7In version plugin: WildStacker-2023.3-b45.jar

@OmerBenGera I've added more information above, what do you recommend I go back to version 35 and wait for you to correct it?

Your spark heap does not show anything related to WildStacker. Try using dumpheap, and send me the output file so I can inspect it.

@Xayanix Have you looked at the latest dev build? Is it better now?

OmerBenGera avatar Apr 22 '24 13:04 OmerBenGera

@OmerBenGera there is still memory leakage spark: https://spark.lucko.me/ulh2wRYUeg spark heapsummary: https://spark.lucko.me/gla6pQD7In version plugin: WildStacker-2023.3-b45.jar

@OmerBenGera I've added more information above, what do you recommend I go back to version 35 and wait for you to correct it?

Your spark heap does not show anything related to WildStacker. Try using dumpheap, and send me the output file so I can inspect it.

@Xayanix Have you looked at the latest dev build? Is it better now?

I didnt check it, fixed it on my own. I told u where leak was

Xayanix avatar Apr 27 '24 16:04 Xayanix

@OmerBenGera there is still memory leakage spark: https://spark.lucko.me/ulh2wRYUeg spark heapsummary: https://spark.lucko.me/gla6pQD7In version plugin: WildStacker-2023.3-b45.jar

@OmerBenGera I've added more information above, what do you recommend I go back to version 35 and wait for you to correct it?

Your spark heap does not show anything related to WildStacker. Try using dumpheap, and send me the output file so I can inspect it. @Xayanix Have you looked at the latest dev build? Is it better now?

I didnt check it, fixed it on my own. I told u where leak was

add in Pull requests please, help both him and me, if you can of course, we would be very grateful

SrMonsterYT avatar Apr 28 '24 00:04 SrMonsterYT