Add a metadata to fake players so external plugins can detect them

[SkytAsul]

Minecraft's Version

1.20.4

Plugin's Version

2023.3

Describe the bug

Not a bug, but you told me to open an issue and that's the only template I am allowed to choose. Anyway, it's related to this discussion: https://github.com/BG-Software-LLC/WildLoaders/discussions/81 Bukkit#getPlayers maybe does not return your NPCs, but some player events are still fired with the NPCs. The "NPC" metadata is quite common (Citizens does it, for instance) so that would be nice to add, and it does not have any drawback afaik.

To Reproduce

nothing

Additional Information

No response

[OmerBenGera]

Which events are fired? I want to get rid of them, and I will also add the metadata.

[SkytAsul]

I cannot tell exactly. I will get back to you once the user that reported the bug in my plugin answers. In the meantime yeah it would be nice to have the metadata.

[OmerBenGera]

Have you looked into the events that are fired?

[OmerBenGera]

Any news regarding this?

[SkytAsul]

Sorry, I've got no response about it. I will try to reproduce and let you know.

[SkytAsul]

I've succeeded in reproducing the problem: it is caused by World#getPlayers() returning a collection containing WildLoaders fake players.

[OmerBenGera]

Check out latest dev build, NPCs should now have the "NPC" metadata.

[SkytAsul]

Thank you!

[OmerBenGera]

Let me know if that all what you need and that it works

[SkytAsul]

Sorry not to have answered before, it works! Thank you very much.