Wild Chests dropped tps

[mrunningmasterc]

Minecraft's Version

git-Purpur-2090

Plugin's Version

WildChests-2023.3-b25.jar

Describe the bug

Chests are causing a drop in tps, possible that a crash will come soon.

https://spark.lucko.me/vpYr15ID6Q

https://spark.lucko.me/ARQhEqo3Ua

To Reproduce

Insert latest version Run Latest Paper Then start using chests.

Additional Information

No response

[mrunningmasterc]

Whenever there's more players on using them it starts to get even worse.

[HamtaBot]

seems to be caused by crafting chests and seems to happen since build 25 i did not have that issue on build 24

[mrunningmasterc]

Yea I had to revert to B24 but since I’m on version 1.20.2 some of the chests don’t work. I’m hoping this gets fixed soon.

[HamtaBot]

@OmerBenGera should be here to fix it soon , just wait a little bit

[OmerBenGera]

Check out latest dev build, let me know how it is doing.

[HamtaBot]

testing it in 2 hours

[HamtaBot]

major dupe bug came with the update every suction chest check if a player is killing mobs and the suction chest is "FULL" it will double the drops on the ground making items on the ground going from 1000 to 2000 to 4000 to 8000 (every seconds like in the video)

https://github.com/BG-Software-LLC/WildChests/assets/62488520/fa15b5b5-4fb3-4b89-b8e0-7b9f1a5fdaac

[OmerBenGera]

Fixed with latest dev build @HamtaBot

[HamtaBot]

Fixed with latest dev build @HamtaBot

Unfortunately I will not be able to test this until nov 27 due to Christmas’s , I’ll keep you updated when the build will be tested

[mrunningmasterc]

https://github.com/BG-Software-LLC/WildChests/assets/63335629/967dcf8c-a24f-4e0d-b64e-a9a63ae4bf65

I did a similar test here where the chunk collector chest was full and it seems like the latest dev version fixed it. It doesn't duplicate numbers.

[HamtaBot]

720.mp4

I did a similar test here where the chunk collector chest was full and it seems like the latest dev version fixed it. It doesn't duplicate numbers.

Well you need to kill mobs very fast . We have fast kill enabled and k was using autoclick

[OmerBenGera]

720.mp4 I did a similar test here where the chunk collector chest was full and it seems like the latest dev version fixed it. It doesn't duplicate numbers.

Well you need to kill mobs very fast . We have fast kill enabled and k was using autoclick

It happened even without that, only by dropping items on ground.

[HamtaBot]

720.mp4 I did a similar test here where the chunk collector chest was full and it seems like the latest dev version fixed it. It doesn't duplicate numbers.

Well you need to kill mobs very fast . We have fast kill enabled and k was using autoclick

It happened even without that, only by dropping items on ground.

alright im testing this to night and will come back here to tell you if perf issues are fixed

[HamtaBot]

for now i did a spark with 30 players online we can see wilchests on it but thats due to ShopGuiPlus and i believe its being inestigated , https://spark.lucko.me/pVTNl7vtUi i'll test it in a few hours with 80-90 players online and compare with old spark to see if it fixed lags issue

[HamtaBot]

here is a spark with 110 players online https://spark.lucko.me/pwkL1G01fQ i have no idea if it still needs optimizations

[Superalex0102]

here is a spark with 110 players online https://spark.lucko.me/pwkL1G01fQ i have no idea if it still needs optimizations

As I see the crafter seems to eat a lot of tps.

Did the problems with ShopGui+ got fixed?

[HamtaBot]

shopguiplus + issue got reduced but not fixed until the dev of it do something also we are only 35 players online and wildchests is already taking a lot of ticks https://spark.lucko.me/3YlOUCOCOY its almost taking more than wildstacker which should not be the case, atleast for my server

[OmerBenGera]

shopguiplus + issue got reduced but not fixed until the dev of it do something also we are only 35 players online and wildchests is already taking a lot of ticks https://spark.lucko.me/3YlOUCOCOY its almost taking more than wildstacker which should not be the case, atleast for my server

The lag comes from ShopGUIPlus, and it is already known and I cannot do anything on that. Don't use ShopGUIPlus for WildChests, simple fix.

[OmerBenGera]

Is this still relevant? If it was SGP, then there's an issue already opened regarding this.

[HamtaBot]

Yes, when checking spark profiler Craft chests seems to still takes a lot of tick, when checking my spark it takes the same amount of SellChest with shopgui+ issue so i guess it can be optimized https://spark.lucko.me/WWrN0BMjrw there was only 70 players online we usually hit 150 and its the double when we are 150

[OmerBenGera]

@HamtaBot Check out latest dev build, it should be much better

[HamtaBot]

@HamtaBot Check out latest dev build, it should be much better

it is indeed VERY VERY much better Thank you for that fix we now need shopgui+ dev to wake up

[OmerBenGera]

@HamtaBot Check out latest dev build, it should be much better

it is indeed VERY VERY much better Thank you for that fix we now need shopgui+ dev to wake up

Send me the spark profiler, I want to take a look at it myself as well.

[HamtaBot]

@HamtaBot Check out latest dev build, it should be much better

it is indeed VERY VERY much better Thank you for that fix we now need shopgui+ dev to wake up

Send me the spark profiler, I want to take a look at it myself as well.

https://spark.lucko.me/3NGvLyxkv6

[OmerBenGera]

I am pretty sure everything here is fixed, no? @HamtaBot

[HamtaBot]

I am pretty sure everything here is fixed, no? @HamtaBot

yes it is fully fixed, not a single tick over 50 poping with ShopGui+ or wildchests great job !