SuperiorSkyblock2 icon indicating copy to clipboard operation
SuperiorSkyblock2 copied to clipboard

Feature/biome environement

Open SwartZCoding opened this issue 3 years ago • 10 comments

  • Add biome-environment section to biomes.yml (Key : Biome, Value : Environment (Can be Normal, Nether, The_End))
  • Add Check on BiomeButton
  • Add new messages on config (Need to be traslate for : iw-IL, pl-PL, vi-VN, zh-CN). Others languages are done !
  • Need to be tested

TODO : Add setBiome methods with World in constructor to change biome of a specific World

SwartZCoding avatar Sep 11 '22 14:09 SwartZCoding

Shoukld be merged into dev, not master.

OmerBenGera avatar Sep 11 '22 16:09 OmerBenGera

@OmerBenGera we need method for set biome in specific world.

NewZAZ avatar Sep 11 '22 19:09 NewZAZ

Just made some change on #1353 to make this changes.

However, I don't know the plugin code well enough, to add the biome change functionality independent of the worlds (Normal, Nether, End).

SwartZCoding avatar Sep 16 '22 14:09 SwartZCoding

Any news regarding this?

OmerBenGera avatar Oct 08 '22 14:10 OmerBenGera

Any news regarding this?

Don't have time atm to finish it, maybe in some week. But it's a good feat to add fast ^^.

SwartZCoding avatar Oct 08 '22 18:10 SwartZCoding

Hello, if it is possible you could put that you need the permission superiorskyblock.biome. to be able to put vip biomes and for user ? then once this pull request is added you could also change the biome with the command /island admin biome ?

Zarkness2 avatar Oct 14 '22 00:10 Zarkness2

Hello, if it is possible you could put that you need the permission superiorskyblock.biome. to be able to put vip biomes and for user ? then once this pull request is added you could also change the biome with the command /island admin biome ?

You can assign permissions to buttons in menus. Check out the wiki for more imformation regarding this.

OmerBenGera avatar Oct 14 '22 06:10 OmerBenGera

Hello, if it is possible you could put that you need the permission superiorskyblock.biome. to be able to put vip biomes and for user ? then once this pull request is added you could also change the biome with the command /island admin biome ?

You can assign permissions to buttons in menus. Check out the wiki for more imformation regarding this.

ok, thank you very much, but you missed to answer me if it can be changed also from the command for admins /island admin biome

Zarkness2 avatar Oct 14 '22 07:10 Zarkness2

Hello, if it is possible you could put that you need the permission superiorskyblock.biome. to be able to put vip biomes and for user ? then once this pull request is added you could also change the biome with the command /island admin biome ?

You can assign permissions to buttons in menus. Check out the wiki for more imformation regarding this.

ok, thank you very much, but you missed to answer me if it can be changed also from the command for admins /island admin biome

Open a feature request regarding the admin biome command :)

OmerBenGera avatar Oct 14 '22 07:10 OmerBenGera

Hello, if it is possible you could put that you need the permission superiorskyblock.biome. to be able to put vip biomes and for user ? then once this pull request is added you could also change the biome with the command /island admin biome ?

You can assign permissions to buttons in menus. Check out the wiki for more imformation regarding this.

ok, thank you very much, but you missed to answer me if it can be changed also from the command for admins /island admin biome

Open a feature request regarding the admin biome command :)

no offense but that's a little ugly once it is being done for the menu and could be added for the command I say it would be nice, too wait almost 5 or 6 months to respond to see if it will be added or not I prefer to pass to open another feature request

Zarkness2 avatar Oct 14 '22 08:10 Zarkness2

I am closing this as it doesn't go anywhere. If you want it to be accepted, make a new PR with all the changes I requested.

OmerBenGera avatar Mar 18 '23 18:03 OmerBenGera