SuperiorSkyblock2 icon indicating copy to clipboard operation
SuperiorSkyblock2 copied to clipboard

Listener cause lags

Open nivcoo opened this issue 2 years ago • 11 comments

Minecraft's Version

1.18.2

Plugin's Version

b646

Describe the bug

Hello, look the spark https://spark.lucko.me/dIiRkEDXml you have fixed the pistons performance issue but like you can see, i've performance issue with Entity spawn and StackedBlock. (1.6% for Entity and 0.6 for stacked block).

If you can fix that i think the plugin will be well optimized. Thx

To Reproduce

Use SS2 with players.

Additional Information

No response

nivcoo avatar May 15 '22 14:05 nivcoo

About the entities; there's no much that can be optimized there. About the stacked blocks; why do you have physics listener enabled for stacked blocks in the config file? Is there a reason you enabled it?

OmerBenGera avatar May 20 '22 14:05 OmerBenGera

About the entities; there's no much that can be optimized there.

Sad that you can't optimise more, for me it's also the things that consume the most (60-70% of superior's consumption in spark)

WarnDa avatar May 20 '22 18:05 WarnDa

I no longer remember why i've enabled the physics listener, i think it's because i've sponge in stacker and if i disable the feature and place water against the sponge it will create wet sponge and remove the stacker

nivcoo avatar May 20 '22 18:05 nivcoo

About the entities; there's no much that can be optimized there.

Sad that you can't optimise more, for me it's also the things that consume the most (60-70% of superior's consumption in spark)

Upload a spark.

OmerBenGera avatar May 20 '22 18:05 OmerBenGera

I no longer remember why i've enabled the physics listener, i think it's because i've sponge in stacker and if i disable the feature and place water against the sponge it will create wet sponge and remove the stacker

Stacked blocks should not transform into wet sponges. If they do, open a separate issue regarding this.

OmerBenGera avatar May 20 '22 18:05 OmerBenGera

So, look this issue https://github.com/BG-Software-LLC/SuperiorSkyblock2/issues/97, why do you say to me to turn on this feature if it's not linked with sponge issue ?

nivcoo avatar May 20 '22 18:05 nivcoo

About the entities; there's no much that can be optimized there.

Sad that you can't optimise more, for me it's also the things that consume the most (60-70% of superior's consumption in spark)

Upload a spark.

Already do on the other ticket that you closed

WarnDa avatar May 20 '22 18:05 WarnDa

So, look this issue #97, why do you say to me to turn on this feature if it's not linked with sponge issue ?

Ok it's why i've activated this issue, before i used ss2 in 1.12, so now i can disable that

nivcoo avatar May 20 '22 18:05 nivcoo

image https://spark.lucko.me/Juf9HyGF7t

WarnDa avatar May 20 '22 22:05 WarnDa

So, look this issue #97, why do you say to me to turn on this feature if it's not linked with sponge issue ?

I told you its fixed on versions above 1.13, but if you dont use 1.13 or above, enable it. You are using 1.18 and therefore you should not enable it.

OmerBenGera avatar May 21 '22 06:05 OmerBenGera

I will look into optimizing it in a future update. For now, I am keeping this opened :)

OmerBenGera avatar May 21 '22 07:05 OmerBenGera

Have you checked recent versions? There should be improvements - let me know what you think.

OmerBenGera avatar Sep 03 '22 06:09 OmerBenGera

I will try it thx

nivcoo avatar Sep 03 '22 07:09 nivcoo

@nivcoo Have you tried it?

OmerBenGera avatar Sep 16 '22 06:09 OmerBenGera

I think it works :p

nivcoo avatar Sep 18 '22 18:09 nivcoo

Great. If you encounter lags again, let me know

OmerBenGera avatar Sep 18 '22 20:09 OmerBenGera