SuperiorSkyblock2 icon indicating copy to clipboard operation
SuperiorSkyblock2 copied to clipboard

Entity limit issue

Open WarnDa opened this issue 2 years ago • 12 comments

Minecraft's Version

1.17 pufferfish

Plugin's Version

b586

Describe the bug

Player can get more mobs than the limit, sometimes it doesn't could well mobs (it counts 0 stacks), so player can spawn new mobs, and after 5mn it will count again mobs (the old one + the new one) and player will get 2x more mobs than the limit

To Reproduce

I still don't know exactly how to reproduce. Sometimes when player come back to his island it says player has 0 stack instead of the right amount

Additional Information

No response

WarnDa avatar Apr 09 '22 20:04 WarnDa

There is more than 30 stacks, but it counts currenty 20 stacks (the green number) "quantité actuelle sur l'île" means "current quantity" image

WarnDa avatar Apr 12 '22 11:04 WarnDa

There is more than 30 stacks, but it counts currenty 20 stacks (the green number) "quantité actuelle sur l'île" means "current quantity" image

Try replicating the issue on localhost where you only have SSB & stacker plugin installed

OmerBenGera avatar Apr 12 '22 14:04 OmerBenGera

Any news regarding this?

OmerBenGera avatar Apr 22 '22 13:04 OmerBenGera

The update : https://hub.bg-software.com/job/SuperiorSkyblock2/597/changes fixes the placeholder issue, so fine on this, but you can still get more mobs than the maximum stack

But now it can detect the good amount of mobs (with the placeholder) so it should stop the mobs from spawning it it's already upper the limit

WarnDa avatar Apr 24 '22 22:04 WarnDa

Edit : still the issue and I don't know how to reproduce it... So I'll close it and I'll see with my dev to check the code to find the issue

WarnDa avatar Apr 26 '22 14:04 WarnDa

Edit : still the issue and I don't know how to reproduce it... So I'll close it and I'll see with my dev to check the code to find the issue

Let's keep this opened until we find why it occurs or when at least.

OmerBenGera avatar Apr 28 '22 17:04 OmerBenGera

Any news regarding this?

OmerBenGera avatar May 27 '22 09:05 OmerBenGera

Sometimes when player come back to his island it says player has 0 stack instead of the right amount

I'm still on this, it wouldn't possible to add debug on this ? As it happens rarely and not on all players it's nearly impossible to find how to reproduce it.

It's maybe when it needs to calculate many islands so it forgot some, if you have too much mobs so it skips some mobs, or if the plugin doesn't have time to calculate mobs, so it counts 0

WarnDa avatar May 27 '22 09:05 WarnDa

Sometimes when player come back to his island it says player has 0 stack instead of the right amount

I'm still on this, it wouldn't possible to add debug on this ? As it happens rarely and not on all players it's nearly impossible to find how to reproduce it.

It's maybe when it needs to calculate many islands so it forgot some, if you have too much mobs so it skips some mobs, or if the plugin doesn't have time to calculate mobs, so it counts 0

When the island is loaded after it was unloaded (and there's no cooldown), all mobs will be recalculated - no mob will be skipped.

OmerBenGera avatar May 27 '22 09:05 OmerBenGera

Yes but sometimes rescan fail, that’s why some debug when a mob is scanned With the mob type and the count would be cool

WarnDa avatar May 27 '22 10:05 WarnDa

Any news regarding this?

OmerBenGera avatar Sep 03 '22 06:09 OmerBenGera

Hello,

As you didn't add any debug or things to fnd a way to reproduce it, can't do nothing So we can close it and when I'll get time I'll try to add debug with a dev

WarnDa avatar Sep 25 '22 19:09 WarnDa

Hello,

As you didn't add any debug or things to fnd a way to reproduce it, can't do nothing So we can close it and when I'll get time I'll try to add debug with a dev

Hey, I changed the debug system. Now you can use /is admin debug + tab to get a list of available actions to debug - including entity_spawn and entity_despawn. Try using this feature, let me know if it helps with debugging the issue.

OmerBenGera avatar Oct 29 '22 10:10 OmerBenGera

Okay thanks

I can't test until some weeks once I'll update my server, and it might be fixed with the other fixes you did. So if you want to close it and if the bug appear again I would re-up the ticket

WarnDa avatar Nov 12 '22 11:11 WarnDa

I still got the issue (currently 130 players on) and enabled the debug. Some players get their randomly on 0, so they can bypass the limit

here are some logs : https://pastebin.com/mDNpefvT

But I still don't know how they reproduce this issue, but it happens a lot :(

WarnDa avatar Dec 01 '22 18:12 WarnDa

I still got the issue (currently 130 players on) and enabled the debug. Some players get their randomly on 0, so they can bypass the limit

here are some logs : https://pastebin.com/mDNpefvT

But I still don't know how they reproduce this issue, but it happens a lot :(

Hey, the pastebin does not exist anymore. Mind re-uploading it?

OmerBenGera avatar Dec 01 '22 20:12 OmerBenGera

I still got the issue (currently 130 players on) and enabled the debug. Some players get their randomly on 0, so they can bypass the limit here are some logs : https://pastebin.com/mDNpefvT But I still don't know how they reproduce this issue, but it happens a lot :(

Hey, the pastebin does not exist anymore. Mind re-uploading it?

https://hastebin.com/zewaliketa.less

WarnDa avatar Dec 01 '22 20:12 WarnDa

I still got the issue (currently 130 players on) and enabled the debug. Some players get their randomly on 0, so they can bypass the limit here are some logs : https://pastebin.com/mDNpefvT But I still don't know how they reproduce this issue, but it happens a lot :(

Hey, the pastebin does not exist anymore. Mind re-uploading it?

https://hastebin.com/zewaliketa.less

Well it doesn't say much, if you have more than one island you debug, it will be a mess.

OmerBenGera avatar Dec 01 '22 20:12 OmerBenGera

entity_spawn

There is no command to debug only an island ?

WarnDa avatar Dec 01 '22 20:12 WarnDa

entity_spawn

There is no command to debug only an island ?

No. Again, the plugin recalculates the entities when islands are loaded again, so even if they can bypass the limit, once they go away and come back, it will recalculate entities again. Unless you don't have a specific steps to replicate the bug, I can't help with fixing it.

OmerBenGera avatar Dec 01 '22 20:12 OmerBenGera

entity_spawn

There is no command to debug only an island ?

No. Again, the plugin recalculates the entities when islands are loaded again, so even if they can bypass the limit, once they go away and come back, it will recalculate entities again.

Some islands get 41 chicken instead of 10 When you are more than one on the island it may recalculate wrong

OHHH I didn't try to do things like /home or /back instead of /is, maybe it doesn't detect so it doesn't recalculate

WarnDa avatar Dec 01 '22 20:12 WarnDa

Find out how they spawn chickens and try spawning them yourself (also, check the current entity counts using placeholders) Also, use the debug command to see if the new mobs are tracked or not.

OmerBenGera avatar Dec 01 '22 20:12 OmerBenGera

https://youtu.be/-dTpYgH1jl4 https://pastebin.com/pegKf9uB

I tried to spawn mobs with egg it doesn't count them (all my limits are on) Same on my own server

(player reported my it could be due to reproduction, but I can't test as limit are not really working at all, as you see on the video)

WarnDa avatar Dec 02 '22 18:12 WarnDa

They are stacking into that cow, why would it increase the entity count? Also, the log you sent is for untracking entities, not for tracking them.

OmerBenGera avatar Dec 02 '22 18:12 OmerBenGera

I should get 1 stacked cow it counts 0 but I'll redo a video after lunch to explain

WarnDa avatar Dec 02 '22 18:12 WarnDa

I should get 1 stacked cow it counts 0 but I'll redo a video after lunch to explain

Enable debug for entity spawn as well as despawn. Then, leave the chunk, wait a few moments and come back. Check if you see the despawn when you leave the chunk and the spawn when you come back

OmerBenGera avatar Dec 02 '22 18:12 OmerBenGera

It doesn't track entity spawning currently, idk why : https://pastebin.com/A7p5KCiC https://youtu.be/suD4AMpG2do image

WarnDa avatar Dec 02 '22 19:12 WarnDa

I disconnected and reconnected, there was one stack of cow, I spawned more mobs that stacked into the current cow, it downs the stack to 0 : https://youtu.be/mQh8Q7DDOZI

WarnDa avatar Dec 02 '22 19:12 WarnDa

When I bread mobs it doesn't detect the new stack : https://youtu.be/xcWDj3WJCP4

Also there is a longer video with the issue from scratch : (https://youtu.be/7jjY_jrW5ZY) Here you can see all the issues, mobs are not counted until server restart, and when a new mob spawn and stack to the other, it decrease the mob count. Recorded with default superiorskyblock config, paper 1.19.2

WarnDa avatar Dec 10 '22 10:12 WarnDa

any news ?

WarnDa avatar Dec 22 '22 17:12 WarnDa