beast icon indicating copy to clipboard operation
beast copied to clipboard

logspacing in pdf1d

Open schen70 opened this issue 1 month ago • 1 comments

When the class pdf1d is run for radius bins, the bins are set to log spaced bins

            if logspacing:
                self.min_val = math.log10(self.min_val)
                self.max_val = math.log10(self.max_val)
                tgridvals = np.log10(tgridvals)

However the unique values of tgridvals , uniqvals are defined before this point, but are not transformed into log space alongside it. This results in the value error "Not all the physics grid model points mapped to 1d ppdf bins - should not happen". I don't know why the example metal_small does not run into this issue.

schen70 avatar Nov 10 '25 23:11 schen70

That is odd. I agree, the metal_small example not having this issue is odd. And probably a clue too. I'm at a meeting this week, so will likely not have time to look at this for a week or two.

karllark avatar Nov 11 '25 15:11 karllark