backup-container icon indicating copy to clipboard operation
backup-container copied to clipboard

Support for multiple table schemas

Open mark-walle opened this issue 5 years ago • 1 comments

The verifyBackup function on (this line)[https://github.com/BCDevOps/backup-container/blob/59699357cc6908bc9f1d29c907eec54fffc86762/docker/backup.sh#L1198] uses a WHERE table_schema='${TABLE_SCHEMA}' condition, with TABLE_SCHEMA defaulting to public.

This works well when there is only one table schema value; however, across multiple databases or even within the same database, there may be multiple differing table schema values. In that case, the condition above would miss those schema.

mark-walle avatar Jul 29 '19 17:07 mark-walle

Initial support, as described above was added in PR #29.

Support for changing the TABLE_SCHEMA on a per database level would need to be added to the database specification in the settings/config.

Perhaps something like this; <Hostname/>[:<Port/>]/<DatabaseName/>[.<SchemaName/>] postgresql:5432/TheOrgBook_Database.my_schema Where:

  • Database Serve Name: postgresql
  • Database Port (Optional): 5432
  • Database Name: TheOrgBook_Database
  • Schema Name (Optional): my_schema

WadeBarnes avatar Sep 12 '19 14:09 WadeBarnes