react-native-card.io icon indicating copy to clipboard operation
react-native-card.io copied to clipboard

Android Support

Open cmmouritsen opened this issue 9 years ago • 12 comments

I see that Android Support is on your to-do. I was just curious how soon that might be available.

cmmouritsen avatar Nov 11 '15 16:11 cmmouritsen

@cmmouritsen You can see the progress here: https://github.com/BBB/react-native-card.io/pull/2

Any help would be appreciated!

BBB avatar Nov 11 '15 19:11 BBB

Awesome. Thanks. Understood on help being appreciated. I have a few other things I need to finish up first, then I'll see if I can help.

cmmouritsen avatar Nov 12 '15 17:11 cmmouritsen

So I obviously haven't got around to helping with this. I do have a related question: If I have an app for iOS and Android that has a dependency on this library, would you expect it to crash immediately upon starting the app on Android?

cmmouritsen avatar Feb 13 '16 01:02 cmmouritsen

@cmmouritsen That sounds very likely. There is currently no code in to repo to support android. feature/android has some support, perhaps you'd like to try that?

BBB avatar Feb 15 '16 11:02 BBB

@BBB I started looking at what it would take to make this work on Android as I have a need to implement Card IO in my react native app and noted a fairly large difference between the iOS SDK and Android - On iOS you can embed the view into another view which is the way its implemented here but on Android it seems you can only open it as its own Activity. Obviously that isn't an issue but for this implementation specifically what were you planning to do? The inconsistency would not be something easily overcome.

rmevans9 avatar Feb 15 '16 12:02 rmevans9

@rmevans9 That's precisely the issue I found last time I tried to implement it. I was able to show the Activity, but not able to send the scanning info back out of it IIRC. I was planning on looking around at some other react-native android modules to see if anyone has worked around it. I've not had the time unfortunately!

BBB avatar Feb 17 '16 15:02 BBB

@BBB So I am really digging into implementing this for Android. It will have to be via an Activity and won't be able to be embedded on in a view. For my use case that is completely fine but is different then the iOS implementation. As such I am going to try and standardize between the two OSes. Interested in a PR when I get that wrapped up?

rmevans9 avatar Mar 15 '16 00:03 rmevans9

@rmevans9 I don't see any issues with that. :+1:

BBB avatar Mar 15 '16 13:03 BBB

Hi,

Are you still working on Android support for this project? Do you have an idea when it could be finished?

Thanks. Daniel

dankremniov avatar Jul 18 '16 10:07 dankremniov

@Daniellt1 I've not got any need for the android version at the moment so development has stalled. Feel free to contribute on #2 though.

Did you get anywhere @rmevans9?

BBB avatar Jul 18 '16 11:07 BBB

Hey guys,

I have not, got pulled off onto other higher priority projects. I might be coming back to this soon... just no timeline yet.

Sorry!

rmevans9 avatar Jul 18 '16 12:07 rmevans9

Hey! As this module seems to be unmaintained I wrote a complete and cross-platform component for card.io. Feel free to contribute!

https://github.com/Kerumen/react-native-awesome-card-io

Kerumen avatar Aug 30 '16 16:08 Kerumen