Bartosz Korczyński comments

Results 69 comments of


                                            Bartosz Korczyński

[Experiment] Make Avalonia.Skia compatible with both SkiaSharp 2.88 and 3.0

I've tried this in my App with skia 3.0.0-preview.1.8, I didn't spot any bugs (tho the app is not graphically intensive), but I have notice the default for the image...

DataContext bindings in ControlTemplate leak memory

With those two PRs it works much better now. There is, however, still one small "semi-leak" 1. Press Add Tab three times 2. Press Close All Tabs One of the...

Wrap type conversions in try-catch to prevent crashes due to unhandled exceptions

@cla-avalonia agree

Wrap type conversions in try-catch to prevent crashes due to unhandled exceptions

Typing a letter in a number field is an user error and it would spam the log.

Wrap type conversions in try-catch to prevent crashes due to unhandled exceptions

> Without exceptions or messages in log it would be difficult to identify any errors in a Converter. The log level can be customized. The exception will be shown in...

Support nested types in DataTemplate.DataType

+1, it prevents from using CompiledBindings in few places :(

Popup with a placement target pops up in a wrong position with compositor in adorner layer

I've checked this again in latest stable Avalonia 11.0.0, but sadly it is still bugged. Sorry for the ping, but let me ping @kekekeks as I believe if anybody might...

Popup with a placement target pops up in a wrong position with compositor in adorner layer

I've debugged the code and I was able to find the offending line: in Avalonia 0.10 the bounds here were taken directly from TransformedBounds property: https://github.com/AvaloniaUI/Avalonia/blob/7739bd9ca3a20a8cb2b10c4ee2ca31337b227f4e/src/Avalonia.Controls/Primitives/AdornerLayer.cs#L183-L187 since this property has...

Cannot select text in multi-line SelectableTextBlock easily

+1 it is pretty annoying. Anyway, thank you a lot for the text rework in Avalonia 11, including new SelectableTextBlock :)

[Question] Sorting the graph

I am gonna add my 5 cents here in case anyone find this issue: for graph layouting [Microsoft Automatic Graph Layout](https://github.com/microsoft/automatic-graph-layout) works very well (and I do agree there is...