rake_new2 icon indicating copy to clipboard operation
rake_new2 copied to clipboard

Test the current algorithm of rake_new2 to look for edge cases

Open BALaka-18 opened this issue 4 years ago • 15 comments

Description

No algorithm can escape edge cases. Your task is to check and test for probable edge cases where you think the algorithm might fail, by trial and error. Test the library on as many texts as you can.

Read : How to use rake_new2

For example : The previous version of this algorithm couldn't handle HTML tags in text. It was resolved in the current version that you see.

NOTE : This may be a multi-assignee issue

Folder Structure, Function details

Create a folder test_cases in the root directory. The folder must contain a .txt file that will contain all the edge cases that you found, with each edge case in a separate line.

Structure : test_cases/edge_cases_file.txt

Acceptance Criteria

  • [ ] The .txt file must be properly formatted.
  • [ ] All instructions provided in the Description must be strictly followed.

Definition of Done

  • [ ] All of the required items are completed.
  • [ ] Approval by 1 mentor.

Time Estimation

Recurring

BALaka-18 avatar Sep 25 '20 18:09 BALaka-18

I'm going to start working on that if it's ok.

etnnth avatar Sep 27 '20 18:09 etnnth

I'm going to start working on that if it's ok.

Assigning it to you @etnnth. Make sure the PR is created after 1st Oct.

BALaka-18 avatar Sep 27 '20 21:09 BALaka-18

Can I also contribute on this

sudhanshutiwari264 avatar Sep 28 '20 14:09 sudhanshutiwari264

Can I also contribute on this

Yes sure. Assigning you too. You can collaborate and discuss with @etnnth too.

BALaka-18 avatar Sep 28 '20 14:09 BALaka-18

@etnnth can we discuss it !

sudhanshutiwari264 avatar Oct 04 '20 09:10 sudhanshutiwari264

@sudhanshutiwari264 yes, sure! How do you want to proceed? For now I have just take a look at the code and made it run a few time on different inputs to get a better idea of what it is doing.

etnnth avatar Oct 04 '20 10:10 etnnth

@etnnth Can we talk on discord ? It will be easier for us to discuss their!

sudhanshutiwari264 avatar Oct 04 '20 10:10 sudhanshutiwari264

Yes discord is fine: https://discord.com/invite/FFFHHy

etnnth avatar Oct 04 '20 10:10 etnnth

Are you guys still working on this, if not I'll assign to someone else, coz my project is going in for another open source contest. So please reply at the latest.

BALaka-18 avatar Nov 17 '20 14:11 BALaka-18

Sorry for the late reply. I'm not working on this for now. I blocked on it because I didn't find a reliable way to decide if something was an edge case or not. What I started however is writing simple test cases. If this is something you are interested I can add a few more and make a pull request.

etnnth avatar Nov 27 '20 20:11 etnnth

@etnnth no problem i'll unassign you. Thanks for you time :)

BALaka-18 avatar Nov 30 '20 07:11 BALaka-18

@BALaka-18 Sorry I have been busy with the exams and internships , so unassigning this . Hope you understand !

sudhanshutiwari264 avatar Dec 09 '20 16:12 sudhanshutiwari264

@BALaka-18 Sorry I have been busy with the exams and internships , so unassigning this . Hope you understand !

Yes absolutely, no problem. Thanks for ur time :)

BALaka-18 avatar Dec 10 '20 06:12 BALaka-18

@BALaka-18 can you please assign this to me?

koolgax99 avatar Jan 06 '21 15:01 koolgax99

@BALaka-18 can you please assign this to me?

Assigned.

BALaka-18 avatar Jan 07 '21 07:01 BALaka-18