ball icon indicating copy to clipboard operation
ball copied to clipboard

Better documentation for the insert and erase Methods of Composite

Open anhi opened this issue 10 years ago • 2 comments

Reported by dstoeckel on 1 Feb 39478218 16:00 UTC As many classes in BALL are derived from Composite (mostly with another super class in between), they often employ Composites methods without mentioning this explicitly. This can have unpredictable effects when using the insert and erase functions, as those tend to invalidate iterators over a composites child list. This should be made explicit by either clarifying the documentation or by throwing appropriate iterator invalidation exceptions.

anhi avatar Feb 20 '15 01:02 anhi

Commented by akdehof on 1 Apr 40940463 23:03 UTC A simple explanation of the invalidation in the documentation should suffice...

anhi avatar Feb 20 '15 05:02 anhi

Commented by dstoeckel on 8 Jun 41343534 13:06 UTC When it's done (tm)

anhi avatar Feb 20 '15 05:02 anhi