Martin Adámek

Results 768 comments of Martin Adámek

I suppose you expect that `em.createQueryBuilder(User).select(['address'])` would expand and select all the properies of `Address` embeddable, right?

Ok, this was harder than expected.

In frontend you could import just the type (something like `import type { Author } from './entities/author';`). > Check type-graphql, the maintainer created an elegant browser shim. Not sure how...

Nope, this will import only the type, so basically only what is inside the `d.ts` file. And there are no decorators, its basically just an interface of the actual class

Importing type will only... import the type :] There cant be any decorators, it will be just a (typescript) type, so basically an interface.

We can definitely add a shim here too, but as I never even used the project with webpack myself, I'd prefer if someone else could do this and test it...

> I'm thinking maybe separating the classes into a validator class and the schema class using nestjs's mapped types might be necessary. I don't really understand what you mean by...

Not supported currently, sure we can have it too. I dont think there is a workaround.

Originally I was thinking only about M:N, do you guys think we need also polymorphic 1:1 and m:1? It looks a bit weird to me, like upside down composite keys...

I just finished hacking the polymorphic embeddables support (#2426), and turns out it wasn't that difficult as I initially though (took less than 2 focused days). I don't want to...