Windows-10-Dark icon indicating copy to clipboard operation
Windows-10-Dark copied to clipboard

Dead zone on Firefox tab-bar in Linux Mint 19.2, Cinnamon

Open catscratchedme opened this issue 5 years ago • 11 comments

Expected behavior: Usually, if you drag your mouse to the very top of the maximized Firefox window, the tabs and new tab button are clickable.

Bug behavior: When using the Windows-10-Dark-3.0-dark window borders, you cannot select tabs or click the new tab button when your mouse is all the way at the top of the screen. Instead, you grab and drag the Firefox window itself.

This bug happens when: The Firefox title bar is removed (Options > Customize > uncheck "Title bar") The Firefox window is maximized. Window borders for Windows-10-Dark-3.0-dark are selected

catscratchedme avatar Dec 21 '19 01:12 catscratchedme

there is a 1px top border when maximized, which probably causes the bug. I'll have a look at it as soon as possible but it should be easy to patch

Elbullazul avatar Dec 21 '19 14:12 Elbullazul

in metacity-1/metacity-theme-3.xml, try replacing

<frame_geometry name="max" title_scale="medium" parent="normal" rounded_top_left="false" rounded_top_right="false">
	<distance name="left_width" value="0" />
	<distance name="right_width" value="0" />
	<distance name="left_titlebar_edge" value="2"/>
	<distance name="right_titlebar_edge" value="2"/>
	<distance name="title_vertical_pad" value="2"/> <!--
							This needs to be 1 less then the
							title_vertical_pad on normal state
							or you'll have bigger buttons		-->
	<distance name="bottom_height" value="1" />
</frame_geometry>

with

<frame_geometry name="max" title_scale="medium" parent="normal" rounded_top_left="false" rounded_top_right="false">
	<distance name="left_width" value="0" />
	<distance name="right_width" value="0" />
	<distance name="left_titlebar_edge" value="2"/>
	<distance name="right_titlebar_edge" value="2"/>
	<distance name="title_vertical_pad" value="2"/> <!--
							This needs to be 1 less then the
							title_vertical_pad on normal state
							or you'll have bigger buttons		-->
	<distance name="bottom_height" value="1" />
	<border name="button_border" left="0" right="0" top="0" bottom="0"/>
</frame_geometry>

Elbullazul avatar Jan 13 '20 15:01 Elbullazul

@Elbullazul Fixed it for me. Currently using Cinnamon v4.4.8.

leogx9r avatar Jan 22 '20 00:01 leogx9r

That fix is not working for me.

Linux Mint v19.3 Firefox v73.0 Cinnamon v4.4.8

catscratchedme avatar Feb 16 '20 20:02 catscratchedme

@Vroop do you have the client-side titlebar enabled?

in settings>customize, on the botttom, is the titlebar checkbox checked?

Elbullazul avatar Feb 17 '20 14:02 Elbullazul

And this broke again. Also using v73 of Firefox.

FTR, @Elbullazul I do have the title bar checkbox selected.

leogx9r avatar Feb 21 '20 17:02 leogx9r

@leogx9r if you have CSD enabled, then yes, it won't work since it's a GTK headerbar and not the metacity titlebar. Try unchecking it and restarting

Elbullazul avatar Feb 21 '20 18:02 Elbullazul

@Elbullazul

do you have the client-side titlebar enabled?

I'm not sure what this means, sorry :(

in settings>customize, on the botttom, is the titlebar checkbox checked?

Yes, I have the Firefox titlebar checkbox unchecked.

My intention is to have the Firefox tabs on the top, so I can throw my mouse up to the edge of the screen and select tabs without concentrating on aim.

catscratchedme avatar Feb 24 '20 22:02 catscratchedme

client-side titlebars (CSD) are window borders drawn by the app itself, instead of the window manager (server-side decorations, SSD).

ex. csd-ssd

left is CSD, right is SSD

can you post a screenshot of the problem? I can't say for sure which one is enabled when the toggle is unchecked

Elbullazul avatar Feb 25 '20 00:02 Elbullazul

Same problem here

How it works now when maximized (clicking doesn't change tabs rather wants to move the window): actual

How it should work: desired

I have the title bar disabled checkbox

SakiiCode avatar Mar 31 '20 18:03 SakiiCode

The screenshots SakiiCode posted describe my situation as well.

catscratchedme avatar Apr 21 '20 21:04 catscratchedme