CQUI_Community-Edition icon indicating copy to clipboard operation
CQUI_Community-Edition copied to clipboard

Refactor AddCityStateRow()

Open lautit opened this issue 6 years ago • 7 comments

As it is being replaced with the RnF implementation of the same. Maybe execution order? To investigate

lautit avatar Oct 03 '18 05:10 lautit

Solves #355

lautit avatar Oct 03 '18 05:10 lautit

This also needs AddInfluenceRow renamed as well. Otherwise only 1 shows in the city state influence list.

jglassmaker avatar Dec 02 '18 03:12 jglassmaker

Any update on this? The bug still exists and makes the mod unusable for the time being.

Have only seen this after installing Rise and Fall, base game was never affected in my experience

oseparovic avatar Dec 10 '18 23:12 oseparovic

I got it working by refactoring AddInfluenceRow to AddInfluenceRowMod as well (thanks to the @jglassmaker comment).

lilgallon avatar Dec 26 '18 10:12 lilgallon

For me I noticed it only affected single player games. If you play multiplayer (even if you're the only non-AI) it doesn't have the same problem with City States (Win 7, Steam install)

oseparovic avatar Dec 28 '18 21:12 oseparovic

@Azurency please have a look at this PR.

Ionaru avatar Feb 11 '19 01:02 Ionaru

Shouldn't the solution be to fix it in the overriding file from expansion1 (not from CQUI, but from the DLC). Not sure though.

ihendriks avatar Feb 27 '19 14:02 ihendriks