microsoft-identity-web
microsoft-identity-web copied to clipboard
Update benchmark-action.yml to use net 9
Update benchmark-action.yml to use net 9
- [x] You've read the Contributor Guide and Code of Conduct.
- [x] You've included unit or integration tests for your change, where applicable.
- [x] You've included inline docs for your change, where applicable.
- [x] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
Description
This pull request includes updates to the .NET version used in the benchmarking process and changes to the build properties for the benchmark project. The most important changes are as follows:
.NET Version Update:
- Updated the .NET version from 8.x to 9.x in the GitHub Actions workflow file
.github/workflows/benchmark-action.ymlto ensure the benchmarks run with the latest version.
Build Properties Update:
- Changed the target framework from
net8.0tonet9.0inbenchmark/Directory.Build.propsto align with the updated .NET version. - Modified the signing properties in
benchmark/Directory.Build.propsto disable assembly signing by settingSignAssemblyandDelaySigntoFalse.
Fixes #3270
Summary
Summary
| Generated on: | 2/27/2025 - 10:37:31 PM |
| Coverage date: | 2/27/2025 - 10:36:33 PM - 2/27/2025 - 10:37:26 PM |
| Parser: | MultiReport (3x Cobertura) |
| Assemblies: | 0 |
| Classes: | 0 |
| Files: | 0 |
| Line coverage: | |
| Covered lines: | 0 |
| Uncovered lines: | 0 |
| Coverable lines: | 0 |
| Total lines: | 0 |
| Covered branches: | 0 |
| Total branches: | 0 |
| Method coverage: | Feature is only available for sponsors |
Coverage
No assemblies have been covered.
We now have a different error, and based on the discussion with Jenny, no further action needed on this now.
{"error":"invalid_client","error_description":"AADSTS7000215: Invalid client secret provided. Ensure the secret being sent in the request is the client secret value, not the client secret ID, for a secret added to app 'f6b698c0-140c-448f-8155-4aa9bf77ceba'. Trace ID: 19585a17-8a9d-4575-b36b-95c2d3bc4600 Correlation ID: 42eb56e7-81f8-4282-879b-36d379d22753 Timestamp: 2025-02-27 22:20:50Z","error_codes":[7000215],"timestamp":"2025-02-27 22:20:50Z","trace_id":"19585a17-8a9d-4575-b36b-95c2d3bc4600","correlation_id":"42eb56e7-81f8-4282-879b-36d379d22753","error_uri":"https://login.microsoftonline.com/error?code=7000215"}