microsoft-identity-web icon indicating copy to clipboard operation
microsoft-identity-web copied to clipboard

TokenAcquisition still needs to implement ITokenAcquisition on OWIN and SDK (This is a downgraded version of the ASP.NET Core one)

Open jmprieur opened this issue 3 years ago • 0 comments

Repro

Actual

In rel/v2, when running the daemon test app, this no longer works (ITokenAcquisition is no longer found when calling .AddMicrosoftGraph

Expected The devapp still works

Cause This is because we've split TokenAcquisition (which implements ITokenAcquirer) and TokenAcquisitionAspNetCore which inherits from TokenAcquisition but also implements ITokenAcquisition. Not that ITokenAcquisition is not the same definition in ASP.NET Core and .NET FW.

Fix:

  • [ ] Have TokenAcquisition also implement ITokenAcquisition
  • [ ] Fix AddTokenAcquisition(this IServiceCollection) to derive the ITokenAcquirer from the ITokenAcquisition (As this is the same implementation)

jmprieur avatar Jul 25 '22 01:07 jmprieur