microsoft-authentication-library-for-objc icon indicating copy to clipboard operation
microsoft-authentication-library-for-objc copied to clipboard

[macOS SDK] Update macOS minimum version to 10.15

Open spetrescu84 opened this issue 1 year ago • 2 comments

Proposed changes

Update macOS minimum version to 10.15

Type of change

  • [x] Feature work
  • [ ] Bug fix
  • [ ] Documentation
  • [ ] Engineering change
  • [ ] Test
  • [ ] Logging/Telemetry

Risk

  • [ ] High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • [ ] Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • [x] Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

spetrescu84 avatar Jun 25 '24 15:06 spetrescu84

@spetrescu84 I noticed that in the MSAL project we have many places where we check the macOS version" "if (@available(macOS 10.15, *))". Can you please remove these checks given than now they're not needed anymore?

nilo-ms avatar Jun 26 '24 08:06 nilo-ms

@spetrescu84 I noticed that in the MSAL project we have many places where we check the macOS version" "if (@available(macOS 10.15, *))". Can you please remove these checks given than now they're not needed anymore?

Removed all instances of if (@available(macOS 10.15, *)) from MSAL Project. Any that are left should be part of IdentityCore project (not all MSID files are) and will removed as part of the IdentityCore PR

spetrescu84 avatar Jun 26 '24 10:06 spetrescu84

Let's merge this PR only after the July release is out

+1

Veena11 avatar Aug 01 '24 19:08 Veena11