microsoft-authentication-library-for-js icon indicating copy to clipboard operation
microsoft-authentication-library-for-js copied to clipboard

Chore/update to react 19

Open arjenbloemsma opened this issue 10 months ago • 6 comments

Please note that this is a "copy" of PR #7467 which got accidentally closed while doing an update to resolve conflicts

React 19 stable has been released on December 5th (see announcement). This PR updates the react packages to version 19 and also sets the peerDependecies to reflect this.

This change will allow msal-react to be used in projects that use react 19 and enables existing projects that use react and msal-react to upgrade to react 19.

All test succeed:

image

See issue #7455

arjenbloemsma avatar Jan 31 '25 10:01 arjenbloemsma

What needs to be done for this to go out of draft.

iampoul avatar Feb 18 '25 07:02 iampoul

@arjenbloemsma we would also like to upgrade our stack to React 19 and we are stuck because of this. Are you ok accepting the suggestion so that we include this in the next release?

antonakospanos avatar Feb 26 '25 11:02 antonakospanos

Similar to others here, our path to React 19 is blocked due to this package. @arjenbloemsma Is this okay to be marked as ready? Is there anything we can do to assist?

JackMorganNZ avatar Feb 28 '25 00:02 JackMorganNZ

@tnorling do you mind taking a look please?

LeonFedotov avatar Mar 02 '25 14:03 LeonFedotov

Really excited for the React 19 support. It's the last package holding up my company's upgrade. Super appreciate @arjenbloemsma opening the PR and others that contribute to the repo.

samuelms1 avatar Mar 03 '25 16:03 samuelms1

Any updates on this? @tnorling @jo-arroyo @peterzenz, the community has been eagerly waiting for react 19 support for 4 months now. Thanks.

julesblancphin avatar Apr 03 '25 10:04 julesblancphin

Is this held up because of genuine reasons? Will it be a good idea if someone confident enough shall fork msal-react and msal-browser and break this seemingly indefinite wait?

binu1-pararath-c5i-ai avatar Apr 10 '25 12:04 binu1-pararath-c5i-ai

Is this held up because of genuine reasons? Will it be a good idea if someone confident enough shall fork msal-react and msal-browser and break this seemingly indefinite wait?

Not sure about why it's being held up but as suggested by some others, simply applying overrides works just fine. I've been using MSAL with React 19 for a couple weeks with no issues. Unrelated, but I had to do the same thing with swagger-ui-react too.

I really appreciate the folks that keep these libraries nice. They're doing a lot.

Here's the post that I followed and it worked perfectly:

I've managed to upgrade to react@19 by adding "overrides" in package.json. Haven't run into any issues since January

"overrides": {
  "@azure/msal-react": {
    "react": "^16.8.0 || ^17 || ^18 || ^19"
  }
}

See https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/7577#issuecomment-2724525164

samuelms1 avatar Apr 14 '25 15:04 samuelms1

Closing in favor of #7735

tnorling avatar May 06 '25 17:05 tnorling