microsoft-authentication-library-for-js icon indicating copy to clipboard operation
microsoft-authentication-library-for-js copied to clipboard

Add react 19 to peer deps

Open lucas-garrido opened this issue 11 months ago • 12 comments

Core Library

MSAL.js (@azure/msal-browser)

Wrapper Library

MSAL React (@azure/msal-react)

Public or Confidential Client?

Public

Description

React 19 is now stable could you update the peer dependencies please ?

lucas-garrido avatar Dec 09 '24 10:12 lucas-garrido

I totally agree with @lucas-garrido. This is currently blocking our app from being upgraded.

arjenbloemsma avatar Dec 14 '24 13:12 arjenbloemsma

Created a PR to address this: #7467

arjenbloemsma avatar Dec 14 '24 15:12 arjenbloemsma

This complete blocker for any react 19 upgrades with SSO

ritwickg avatar Dec 23 '24 08:12 ritwickg

Just mentioned this in the PR, but will also mention it here:

To unblock my project, I've published a npm package of the msal-react fork. This allows us to keep moving forward and use react 19 in dev and test while the official package has not yet been released. Once the new version of official msal-react is released we can simply change back to that package, rebuild and move on.

For those interested in following a similar approach; https://www.npmjs.com/package/@arjenbloemsma/msal-react

arjenbloemsma avatar Dec 24 '24 11:12 arjenbloemsma

Another temporary workaround, from the consuming package.json file:

"overrides": {
    "@azure/msal-react": {
        "react": "^16.8.0 || ^17 || ^18 || ^19"
    }
}

bdbvb avatar Dec 30 '24 14:12 bdbvb

waiting for this..

3pleFly avatar Feb 12 '25 09:02 3pleFly

Please prefer this problem, I have already tested it manually with the described fix and it seems to work very well. We are urgently waiting for the update to use react 19.

marvinjaworski avatar Feb 14 '25 08:02 marvinjaworski

Any updates on this?

julesblancphin avatar Feb 18 '25 11:02 julesblancphin

Any updates on this?

I resolved this issue by updating to the versions: ├── @azure/[email protected] ├── @azure/[email protected]

aclebson-sage avatar Feb 18 '25 14:02 aclebson-sage

Any updates on this?

I resolved this issue by updating to the versions: ├── @azure/[email protected] ├── @azure/[email protected]

FYI, this would be a downgrade/workaround, not really a resolution.

bdbvb avatar Feb 18 '25 15:02 bdbvb

Any updates on this?

I resolved this issue by updating to the versions: ├── @azure/[email protected] ├── @azure/[email protected]

FYI, this would be a downgrade/workaround, not really a resolution.

for this specific case, it was the solution since version constraints on other React packages

aclebson-sage avatar Feb 18 '25 19:02 aclebson-sage

I also am blocked by this

greatzambino avatar Mar 27 '25 20:03 greatzambino

Another temporary workaround, from the consuming package.json file:

"overrides": {
    "@azure/msal-react": {
        "react": "^16.8.0 || ^17 || ^18 || ^19"
    }
}

Looks like a reasonable workaround. Did anyone get into any issues with it?

jansonjc avatar Apr 07 '25 11:04 jansonjc

It seems to be working well on my end

greatzambino avatar Apr 07 '25 19:04 greatzambino

Another temporary workaround, from the consuming package.json file:

"overrides": {
    "@azure/msal-react": {
        "react": "^16.8.0 || ^17 || ^18 || ^19"
    }
}

Looks like a reasonable workaround. Did anyone get into any issues with it?

A week in production, and no issues so far.

User6531 avatar Apr 08 '25 08:04 User6531

Is there an ETA on this?

tibble49 avatar Apr 23 '25 19:04 tibble49

Guys come on, this is not cool. It's been ~5 months and no fix? If you were a one man team, I'd get it, but you ain't

benc-uk avatar Apr 25 '25 23:04 benc-uk

I'm not going to be sympathetic or anything like that. People pay to use Azure AD. RCs for React 19 have been available practically since last year, and it's been 5 months since React released version 19. It's disrespectful.

MarianoVeloso avatar Apr 28 '25 14:04 MarianoVeloso

@sameerag @peterzenz @jo-arroyo @tnorling please advise the community, there has been 0 communication for months now. As @MarianoVeloso mentioned this is a paid product and the lack of response and support is unprofessional.

julesblancphin avatar Apr 28 '25 15:04 julesblancphin

For anyone curious, there's been an update here https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/7722#issuecomment-2836079014

Essentially React 19 support is not a priority for the MS team and there's some additional work required for the PRs that have been opened.

julesblancphin avatar Apr 29 '25 08:04 julesblancphin

I'm not going to be sympathetic or anything like that. People pay to use Azure AD. RCs for React 19 have been available practically since last year, and it's been 5 months since React released version 19. It's disrespectful.

There seems to be a broader issue across multiple MS projects / departments in supporting updated dependency / runtime versions.

A reasonable expectation from customers:

  • Dependency releases a preview version
  • Developers of components that build upon it (like MS) start making sure that their components are compatible
  • Final version of dependency is released (~6 months after preview)
  • Component developers release a version that supports the new dependency (~1 month after release)

What we see instead:

  • Dependency releases a preview version
  • MS is still playing catchup finalizing support for the previous version
  • Final version of dependency is released
  • Next preview version of the dependency is released
  • MS releases a version that supports the new dependency (~6-12 months after release)

When combined with MS's support policy for dependencies, the net effect is that the N-2 version is often deprecated or out of support before N is supported.

timtucker-dte avatar Apr 29 '25 15:04 timtucker-dte