microsoft-authentication-library-for-js icon indicating copy to clipboard operation
microsoft-authentication-library-for-js copied to clipboard

Fixes for esm imports

Open JeroenBoesten opened this issue 1 year ago • 2 comments

This PR fixes some import issues in the builded .d.ts files because we were getting the following error on a couple of files.

 error TS2835: Relative import paths need explicit file extensions in ECMAScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Did you 
mean '../config/Configuration.mjs'?

2 import { ManagedIdentityConfiguration } from "../config/Configuration";

The lack of the for esm required suffixes made it impossible to compile, if you look at some other files like PublicClientApplication those already contains the correct suffixes so this PR just fixes some of the imports that were missing this and should not break any backwards compatibility.

JeroenBoesten avatar Jun 04 '24 15:06 JeroenBoesten

@microsoft-github-policy-service agree

JeroenBoesten avatar Jun 04 '24 15:06 JeroenBoesten

Addressed in #7284

tnorling avatar Oct 10 '24 20:10 tnorling