microsoft-authentication-library-for-js icon indicating copy to clipboard operation
microsoft-authentication-library-for-js copied to clipboard

Do not sign tokens if `reqCnf` is set

Open sameerag opened this issue 2 years ago • 1 comments
trafficstars

  • This PR signs the POP tokens only if the reqCnf is not passed in as a request parameter. This is to enable any clients that choose to sign their tokens. However, please consider this an advanced feature only.
  • This PR also addresses the native flow bug where cnf is to be sent a string instead of a hash!
  • Removes reqCnfHash in the ReqCnfData since we do not use it. It is only internal, so this should not be a breaking change.

sameerag avatar Aug 17 '23 06:08 sameerag

Codecov Report

Merging #6357 (57f86c3) into dev (81d34b4) will decrease coverage by 3.84%. Report is 381 commits behind head on dev. The diff coverage is 61.57%.

Flag Coverage Δ
msal-angular 96.73% <ø> (+0.22%) :arrow_up:
msal-browser 78.85% <ø> (-7.62%) :arrow_down:
msal-common 84.94% <ø> (+0.39%) :arrow_up:
msal-core ?
msal-node 80.66% <ø> (-2.73%) :arrow_down:
msal-node-extensions 68.02% <61.06%> (-7.62%) :arrow_down:
msal-react 94.24% <ø> (-0.45%) :arrow_down:
node-token-validation ?
Files Coverage Δ
extensions/msal-node-extensions/src/Dpapi.ts 100.00% <100.00%> (ø)
.../msal-node-extensions/src/error/NativeAuthError.ts 100.00% <100.00%> (ø)
extensions/msal-node-extensions/src/index.ts 100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/packageMetadata.ts 100.00% <100.00%> (+100.00%) :arrow_up:
...-extensions/src/persistence/DataProtectionScope.ts 100.00% <100.00%> (ø)
...nsions/msal-node-extensions/src/utils/Constants.ts 100.00% <100.00%> (ø)
...sions/msal-node-extensions/src/utils/TypeGuards.ts 100.00% <100.00%> (ø)
lib/msal-angular/src/constants.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.broadcast.service.ts 100.00% <ø> (ø)
lib/msal-angular/src/msal.guard.ts 90.78% <ø> (+0.64%) :arrow_up:
... and 65 more

... and 187 files with indirect coverage changes

codecov-commenter avatar Aug 17 '23 07:08 codecov-commenter

Abandoning this for a later PR.

sameerag avatar May 22 '24 05:05 sameerag