microsoft-authentication-library-for-js icon indicating copy to clipboard operation
microsoft-authentication-library-for-js copied to clipboard

Use inject in MsalRedirectComponent

Open grosch-intl opened this issue 1 year ago • 3 comments

Core Library

MSAL.js v2 (@azure/msal-browser)

Wrapper Library

MSAL Angular (@azure/msal-angular)

Public or Confidential Client?

Public

Description

In the alpha for v3, would you please modify MsalRedirectComponent so that instead of injecting the MsalService via the constructor, you instead use the inject(MsalService) option? If you do that, we can stop providing a constructor in our component for the sole purpose of sending you a service.

Source

External (Customer)

grosch-intl avatar May 10 '23 09:05 grosch-intl

@grosch-intl thanks for the feature request. We'll look into it but as a general rule we're not doing API breaking changes for v3. We're limiting updates to default behavior breaking changes and some tooling enhancements.

@EmLauber can we track this feature request for Angular v3? Thanks!

hectormmg avatar May 10 '23 18:05 hectormmg

@grosch-intl This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale.

ghost avatar May 21 '23 01:05 ghost

Tracking internally and keeping open as a feature enhancement for breaking changes.

EmLauber avatar Jun 02 '23 22:06 EmLauber