microsoft-authentication-library-for-go Remove all TODOs

Remove all TODOs

Open element-of-surprise opened this issue 4 years ago • 2 comments

There are a series of TODOs that range from documenting why certain things happen to possible major bugs.

These need to be removed. They can be found with a simple search for "TODO".

Jan 13 '21 21:01 element-of-surprise

Code TODOs
[x] Clean-up authority validation here
[ ] Review todo of storage.go not expiring tokens here and investigate this. Also foci investigation here
[ ] Write tests for mex document parsing here
[ ] Write tests for resolvers.go - here
[ ] Investigate wstrust.go here
[ ] Document saml attributes here
[x] Review ID Token check here
[x] Use named structs instead of naked structs for mex_document definition here
[ ] Add example code for methods in public client here
[x] Investigate authorization pending/ slow down in device code flow message here
[x] Investigate JWT decoding here
[x] Investigate expiry time for JWT assertion here
[ ] Add example code for methods in confidential client here
Sample TODOS
[ ] Auth code sample here and here
[ ] Use flag package in samples main file instead of if...else chain here

Jan 25 '21 23:01 abhidnya13

I've reviewed the //TODOs and they are mostly about adding more docs in the code, a bug which is tracked separately, missing unit tests etc.

Nothing that would impact public API or behavior.

Feb 03 '23 15:02 bgavrilMS