[Bug] Microsoft.Identity.Client.NativeInterop.targets doesn't respect `GenerateAssemblyInfo=false`

[RussKie]

The embedding must be conditional, otherwise it breaks the build

Repro steps:

test.csproj

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net472</TargetFramework>
    <OutputType>Library</OutputType>
    <LangVersion>latest</LangVersion>
    <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.Identity.Client.NativeInterop" Version="0.16.2" />
  </ItemGroup>
</Project>

Class1.cs

namespace test;
public class Class1 { }

Try to compile the above - it fails because the targets unconditionally embeds non-existing non-generated assembly info:

PS D:\Development\throwaway\Microsoft.Identity.Client.NativeInterop> dotnet build
  Determining projects to restore...
  All projects are up-to-date for restore.
C:\Program Files\dotnet\sdk\8.0.400-preview.0.24312.1\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(311,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [D:\Development\throwaway\Microsoft.Identity.Client.NativeInterop\test.csproj]
CSC : error CS2001: Source file 'D:\Development\throwaway\Microsoft.Identity.Client.NativeInterop\obj\Debug\net472\test.AssemblyInfo.cs' could not be found. [D:\Development\throwaway\Microsoft.Identity.Client.NativeInterop\test.csproj]

Build FAILED.

CSC : error CS2001: Source file 'D:\Development\throwaway\Microsoft.Identity.Client.NativeInterop\obj\Debug\net472\test.AssemblyInfo.cs' could not be found. [D:\Development\throwaway\Microsoft.Identity.Client.NativeInterop\test.csproj]
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:00.89

[xinyuxu1026]

Hi @RussKie , thanks for opening this! Would <EmbeddedFiles Condition="'$(GenerateAssemblyInfo)' == 'true'" Include="$(GeneratedAssemblyInfoFile)"/> resolve this issue? Thanks.

[RussKie]

Yes, that should fix the issue.

[xinyuxu1026]

Thanks! @RussKie , I checked in the change, it should be in next release.

[RussKie]

Great, thank you.

[bgavrilMS]

Hi @RussKie , thanks for opening this! Would <EmbeddedFiles Condition="'$(GenerateAssemblyInfo)' == 'true'" Include="$(GeneratedAssemblyInfoFile)"/> resolve this issue? Thanks.

If it will be fixed in the next release, please set the "milestone" to the next version of MSAL.NET (a milestone should already exist). It'll help partners keep track of fixes.

[KirillOsenkov]

My question is why is it adding the generated assembly info file to embedded files in the first place? Do we know? It's good to have this fix, but what is it trying to do in the first place?

[xinyuxu1026]

Hi @RussKie , the new version of Microsoft.Identity.Client.NativeInterop is released https://www.nuget.org/packages/Microsoft.Identity.Client.NativeInterop/0.17.0, please update to Version="0.17.0"

[KirillOsenkov]

@xinyuxu1026 do you know the answer to my question above? thanks!

[xinyuxu1026]

Hi @KirillOsenkov , I don't know about that.

@gladjohn might know more context.

[KirillOsenkov]

Hi @xinyuxu1026, I followed up with @gladjohn and we both agree that the EmbeddedFiles line should just be deleted.

Instead of adding the condition, could you please just delete the whole line? Thanks!

[inthemedium]

Hi @xinyuxu1026, any progress on deleting the line?

[xinyuxu1026]

Hi @inthemedium , sorry I missed the comment previously, I will work on this removal this week.

[xinyuxu1026]

Hi, this is fixed in Microsoft.Identity.Client.NativeInterop 0.18.0. Please update to that version and see if this works, thanks.

[KirillOsenkov]

I think we can close this, thanks.