microsoft-authentication-library-for-dotnet icon indicating copy to clipboard operation
microsoft-authentication-library-for-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon AzureAD

StrongNamer is abandoned and relies on an obsolete sdk

Open SimonCropp opened this issue 1 year ago • 3 comments

building without .NET Core SDK v2.1 installed gives

StrongNamer requires at least the .NET Core SDK v2.1 to run with 'dotnet build'

SimonCropp avatar Jan 19 '24 04:01 SimonCropp

The fact that the SDK is obsolete is not impactful. The logic will run with a modern runtime. The SDK is just an interface.

bgavrilMS avatar Feb 05 '24 13:02 bgavrilMS

well it is a pretty big blocker for anyone wanting to contribute. ie forcing them to install a deprecated sdk

SimonCropp avatar Feb 06 '24 00:02 SimonCropp

I am able to build MSAL using just: image

You don't need to build StrongNamer, it is just a dependency.

I agree we should get rid of it, and MSAL does publish the full strong name key as per Open Source Foundation recommendations - https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/blob/main/build/MSAL.snk, to allow contributors to do work. However, our integration tests rely on Selenium.WebDriver which is not signed.

When I try to run an integration tests without StrongNamer I get:

Error: System.IO.FileLoadException: Could not load file or assembly 'WebDriver, Version=4.0.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. A strongly-named assembly is required. (Exception from HRESULT: 0x80131044)

Do you know a way around it?

bgavrilMS avatar Feb 06 '24 12:02 bgavrilMS