microsoft-authentication-library-for-dotnet icon indicating copy to clipboard operation
microsoft-authentication-library-for-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon AzureAD

[Feature Request] Deprecate Old WAM

Open gladjohn opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe. Explore options on how to deprecate the old WAM broker

Describe the solution you'd like need to explore possible solutions

Describe alternatives you've considered none

Additional context This will make the new broker the only option in MSAL .Net for WAM

gladjohn avatar Jul 05 '22 16:07 gladjohn

@jmprieur - I was thinking we do this as part of 4.x ? Here's how I see this done:

  1. Figure out how to inject functionality from MIcrosot.Identity.Client.Broker in MSAL. Currently this is done via "WithBrokerPreview". We can leave this as is and I was thinking of removing "WithBroker" from net4*, netstandard and netcore and replacing it with MIcrosot.Identity.Client.Broker.WithBroker. Suggestions welcome.

  2. Deprecate Microsoft.Identity.Client.Desktop package via nuget message which recommends use of MIcrosot.Identity.Client.Broker package instead.

ALTERNATIVE:

  1. Deprecate MIcrosot.Identity.Client.Broker and move all functionality to Microsoft.Identity.Client.Desktop. Should be a drop-in replacement, but we cannot gurantee that the exact scenarios will work.

It's true that Microsoft.Identity.Client.Desktop also has WebView2 support for B2C. I suggest we drop this for now and update our desktop sample instead (the CustomWebUI version). Also, we need to wait for the last missing feature from runtime, i.e. account discovery.

CC @pmaytak @trwalke @neha-bhargava @sameerkapps for suggestions

bgavrilMS avatar Jul 06 '22 10:07 bgavrilMS

@bgavrilMS : I guess I would need to see the before / after in term of API / DevEx to fully understand

jmprieur avatar Jul 06 '22 15:07 jmprieur

@bgavrilMS

do we have a final plan on the deprecation of the old broker? are we doing the alternative approach?

"Deprecate MIcrosot.Identity.Client.Broker and move all functionality to Microsoft.Identity.Client.Desktop. Should be a drop-in replacement, but we cannot gurantee that the exact scenarios will work."

Or

"Deprecate Microsoft.Identity.Client.Desktop package via nuget message which recommends use of MIcrosot.Identity.Client.Broker package instead." and GA the new broker. But the older broker (Desktop) can be used for WebView2 and UWP

@SameerK-MSFT @neha-bhargava @trwalke @pmaytak other ideas?

gladjohn avatar Jan 20 '23 01:01 gladjohn

@SameerK-MSFT assigning this to you since you are working on finalizing the design

gladjohn avatar Jan 25 '23 19:01 gladjohn

Adding this to in-progress to track the deprecation of the old broker and for naming the new APIs

gladjohn avatar Feb 28 '23 17:02 gladjohn