microsoft-authentication-library-for-dotnet icon indicating copy to clipboard operation
microsoft-authentication-library-for-dotnet copied to clipboard

[Feature Request] Change the default Prompt

Open bgavrilMS opened this issue 5 years ago • 6 comments

Which Version of MSAL are you using ? 4.x

What authentication flow has the issue?

  • Desktop / Mobile
    • [x] Interactive
    • [ ] Integrated Windows Auth
    • [ ] Username Password
    • [ ] Device code flow (browserless)
  • Web App
    • [ ] Authorization code
    • [ ] OBO
  • Web API
    • [ ] OBO

Expected behavior If user does not specify a prompt, we should probably not send any prompt and let AAD handle things

Actual behavior We send "Select_account"

bgavrilMS avatar Oct 09 '20 10:10 bgavrilMS

@bgavrilMS why not just use noPrompt, which we already have? Is there a customer ask for this? I would think if they don't specify, then we do don't send a prompt, instead of doing "selectAccount".

jennyf19 avatar Oct 09 '20 16:10 jennyf19

@jennyf19 - I agree, but it's a bit of a breaking change.

Today, if developer does not specify a prompt, we use "select_account". I think we should not send any value, as you say.

Kusto Explorer has spent a lot of time trying to get this to work and have eventually found that "no_prompt" is a better option than "Select_account"

bgavrilMS avatar Oct 12 '20 15:10 bgavrilMS

@bgavrilMS B2C would also prefer this as well.

@jmprieur thoughts on this, as far as the customer perspective?

jennyf19 avatar Oct 13 '20 01:10 jennyf19

We should default to not sending any prompt value, I believe that is the latest recommendation from ests

henrik-me avatar Oct 13 '20 03:10 henrik-me

yes, I agree. "no prompt" provides the best experience and does a select_account when needed. That's what we should use. I'm not even sure that this would break anything (but we'd have to test a bit)

jmprieur avatar Oct 13 '20 07:10 jmprieur

Ok, I added this on the 4.21 release cycle.

bgavrilMS avatar Oct 13 '20 10:10 bgavrilMS