microsoft-authentication-library-for-android icon indicating copy to clipboard operation
microsoft-authentication-library-for-android copied to clipboard

ActionBar overlaps content in Android 15 (SDK 35)

Open chennanoka opened this issue 1 year ago • 7 comments

Describe the bug I was migrating my app to target SDK 35, when I run the app on emulator with SDK 35 the actionBar overlaps the content. I think it's due to the edge to edge feature is turned on by default in SDK 35. I was trying to extend activities in the library to address it but all activities are final class.

Ref: https://developer.android.com/develop/ui/views/layout/edge-to-edge#enable-edge-to-edge-display

Smartphone (please complete the following information):

  • Device: Pixel 9
  • Android Version: 15 (SDK 35)
  • Browser: Chrome
  • MSAL Version: com.microsoft.identity.client:msal:5.7.0

Stacktrace N/A

To Reproduce acquireToken with startAuthorizationFromActivity.

Expected behavior The app content shows below the actionBar

Actual Behavior The actionBar overlaps app content

Screenshots Screenshot 2024-10-16 at 2 50 08 PM

chennanoka avatar Oct 16 '24 18:10 chennanoka

Please use this library attached to test if your scenario is fixed or not. Please let us know if you have broker installed. In case if you have multiple broker installed, please share the logs with us, so that we can send a test apk for broker too.

MSAL.zip cc @somalaya

negoe avatar Nov 15 '24 01:11 negoe

@chennanoka were you able to resolve the issue using the test MSAL library?

somalaya avatar Dec 03 '24 06:12 somalaya

@chennanoka were you able to resolve the issue using the test MSAL library?

Hi Somalaya, sorry for late reply, I'm on a long vacation (to next year) can't confirm it on my dev device. Feel free to pass the ticket if my input is not a must. Thanks.

chennanoka avatar Dec 03 '24 22:12 chennanoka

Hi @somalaya I'm back from vacation, I was trying to use the attached msal-1.0.20241110-1ESdev.3.aar to test the fix. however, it throws errors "can't find supertypes" when compile the app.

The errors are: class com.microsoft.identity.client.exception.MsalException, unresolved supertypes: com.microsoft.identity.common.java.exception.BaseException class com.microsoft.identity.client.ITokenShare, unresolved supertypes: com.microsoft.identity.common.adal.internal.tokensharing.ITokenShareInternal

I looked into the aar file. it's missing the "BaseException" and "ITokenShareInternal". I may need another aar file to test it.

Thanks.

chennanoka avatar Jan 03 '25 15:01 chennanoka

Hi! Any update on when the fix for this will be published?

mikevic18 avatar Jan 19 '25 21:01 mikevic18

Also experiencing this issue, can we have an update on when its likely to be fixed or a suitable workaround?

bez70 avatar Mar 17 '25 08:03 bez70

If somebody still experiencing this issue, this ICustomWebUi implementation helped me: https://github.com/vitalbit/MsalAuthNoTitleBarSample

vitalbit avatar Sep 26 '25 11:09 vitalbit