microsoft-authentication-library-for-android icon indicating copy to clipboard operation
microsoft-authentication-library-for-android copied to clipboard

Clean up native auth msal logging

Open Yuki-YuXin opened this issue 1 year ago • 0 comments

Goal:

  • Review our log statements and reduce to only those that are relevant and useful. Especially the logMethodCall should be much reduced. Not every method call is relevant to know about when debugging.
  • Double check that the existing logs use string interpolation correctly to avoid leaking sensitive information in the logs.

Changes summary:

  • Apply the rule "only logger unknown error" to NativeAuthPublicClientApplication and states. Exception: Sign in has password CodeRequired since it's unusual for the case.
  • Add arguments under method LogSession.logMethodCall tp distinguish callback and coroutine.

Company PR:

https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/2374

Yuki-YuXin avatar Apr 08 '24 09:04 Yuki-YuXin