SCIMReferenceCode icon indicating copy to clipboard operation
SCIMReferenceCode copied to clipboard

[Enhancement] Use AttributeFilter to use newtonsoft only on the scim controllers

Open Tasin5541 opened this issue 3 years ago • 4 comments

Current implementation of the json serialization and de serialization forces user to add newtonsoft to the controllers globally which is a problem if someone tries to integrate the scim endpoints into their application that's using the default text.json library (starting from .net core 3.1) which doesn't support DataContract. In this case adding newtonsoft globally is a big no.

We can use the ActionFilterAttribute Class to ensure the scim endpoints use newtonsoft and the other endpoints keep working as it is.

Tasin5541 avatar Feb 17 '22 17:02 Tasin5541

I would like to work on this if the maintainers approve

Tasin5541 avatar Feb 17 '22 17:02 Tasin5541

I would like to work on this if the maintainers approve

Please go ahead,

boscoMW avatar Feb 24 '22 13:02 boscoMW

Can we get solution without Extension newsoft.json

RohitTopkhane avatar May 09 '24 17:05 RohitTopkhane

@RohitTopkhane Doable, but it would require whole Microsoft.SystemForCrossDomainIdentityManagement/Protocol to be modified to use System.Text.Json. There is a lot of OnInitialization / Initialized all over the place which I am unsure how meaningful they are. In addition, there is also a bunch of Json Serialization / Deserialization Factory stuff that I am not so sure about.

Sefriol avatar May 20 '24 17:05 Sefriol