MSIdentityTools icon indicating copy to clipboard operation
MSIdentityTools copied to clipboard

Update Test-MgCommandPrerequisites.ps1

Open BohrenAn opened this issue 1 year ago • 2 comments

Find-MgGraphCommand with API Version "beta" does not return anything. Therefore the Test-MgCommandPrerequisites Fails

Fixes #

Changes proposed in this pull request

Testing

Documentation

  • [ ] All exported commands have Synopsis, Parameter Descriptions, and at least one Example.

Other links

BohrenAn avatar Feb 03 '24 09:02 BohrenAn

Created Issue in msgraph-sdk-powershell https://github.com/microsoftgraph/msgraph-sdk-powershell/issues/2582

The Parameter -APIVersion should not be used since Microsoft.Graph 2.x anymore. It's a leftover from 1.x

Regards Andres

BohrenAn avatar Feb 12 '24 08:02 BohrenAn

@merill Can someone please review this Pull request?

BohrenAn avatar Feb 21 '24 23:02 BohrenAn

Thanks a lot for the PR @BohrenAn, sorry it took so long. Tx!

merill avatar May 23 '24 13:05 merill

This Merge is introducing new bug for the command Get-MsIdCrossTenantAccessActivity

GROUP\Documents\PowerShell\Modules\Microsoft.Graph.Authentication\2.23.0\custom\Find-MgGraphCommand.ps1:194 char:29
+ …             Write-Error "'$c' is not a valid Microsoft Graph PowerShe …
+               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

SuryenduB avatar Sep 24 '24 20:09 SuryenduB

@merill @BohrenAn , can you please check this ?

SuryenduB avatar Sep 24 '24 20:09 SuryenduB

image image Yeah i'd agree, we need to make sure this can work for both v1 and Beta command Searches.

Lucky only two commands are using Beta commands (Get-MsIdCrossTenantAccessActivity.ps, ConvertFrom-MsIdUniqueTokenIdentifier.ps1), hence why this bug has been not found. image

Ill create a separate issue to work on this

robbieveivers avatar Sep 25 '24 03:09 robbieveivers

Working off Issue #70 Test-MgCommandPrerequisites Must be able to handle v1 and beta via the APIVersion Parameter again

robbieveivers avatar Sep 25 '24 04:09 robbieveivers