terraform-provider-azapi icon indicating copy to clipboard operation
terraform-provider-azapi copied to clipboard

Should `ignore_missing_property` default to `true`?

Open ms-henglu opened this issue 3 years ago • 2 comments

ignore_missing_property is used to suppress plan-diff if there's a property contains secrets like credentials, and not returned from GET response.

The reason it defaults to false is: some APIs might have bugs and they don't recognize some properties, so the update failed silently and these properties are not stored in azure backend. Then if run terraform plan again, users can see there's diff between state and config, then users can realize something is not working properly.

However, it seems property missing caused by containing credentials is much more common than API bugs, so maybe we should change the default value to true?

ms-henglu avatar May 26 '22 01:05 ms-henglu

@grayzu , WDYT?

ms-henglu avatar Jun 06 '22 05:06 ms-henglu

Yes, I agree that we should set this to true by default.

grayzu avatar Jul 28 '22 01:07 grayzu