terraform-azurerm-lz-vending icon indicating copy to clipboard operation
terraform-azurerm-lz-vending copied to clipboard

feat: support for azure AD groups #155

Open kewalaka opened this issue 9 months ago • 0 comments

Overview/summary

This PR introduces support for Entra ID (AAD) groups.

I have thought it might be nice to be able to specify names as well as object IDs, that's why the members + owners contain a map of object ids. This would introduce several "data sources" into the module to make these translations, which may be an undesirable dependency.

This PR fixes/adds/changes/removes

  1. fixes #155

Breaking changes

n/a - new functionality

Testing evidence

Please provide testing evidence to show that your Pull Request works/fixes as described and documented above.

I'm using an integration branch here which is testing a number of fixes including this one, the inputs are:

image

As part of this pull request I have

  • [X] Checked for duplicate Pull Requests
  • [X] Associated it with relevant issues, for tracking and closure.
  • [X] Run and make fmt & make docs to format your code and update documentation.
  • [ ] Created unit and deployment tests and provided evidence.
  • [X] Updated relevant and associated documentation.

Deployment testing looks good, guidance with unit testing would be appreciate 😊, i'm not familiar with the approach.

kewalaka avatar May 05 '24 02:05 kewalaka