terraform-azurerm-lz-vending icon indicating copy to clipboard operation
terraform-azurerm-lz-vending copied to clipboard

Published 20 hours ago • verified publisher icon Azure

feat: Be able to add Partner ID to Subscriptions

Open lukemurraynz opened this issue 11 months ago • 6 comments

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments; they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

It would be good to be able to utilise the Vending Module to apply a Partner ID to the Subscription.

Reference: Link a partner ID to your account that’s used to manage customers

Describe the solution you'd like

To be able to add a Parter ID, in as part of the Subscription vending process.

Additional context

lukemurraynz avatar Mar 03 '24 19:03 lukemurraynz

Hey @lukemurraynz

Seems like a great shout. Sine digging reveals that this is the api we need to think about:

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/managementpartner/resource-manager/Microsoft.ManagementPartner/preview/2018-02-01/ManagementPartner.json

With a good example here:

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/managementpartner/resource-manager/Microsoft.ManagementPartner/preview/2018-02-01/examples/PutPartnerDetails.json

Several properties are unclear to me though. Can you be of any assistance here to help form the required input variable schema?

Thanks

matt-FFFFFF avatar Mar 03 '24 21:03 matt-FFFFFF

Can help, input should really only need to be:

  • partnerId

The system (at least via the Azure Portal), adds in the rest of the information, ie Partner Name, State etc, so depends on how the API handles it - but partnerId will be the key one.

TenantID may need another input variable needed, but that may be able to be dynamically brought in.

lukemurraynz avatar Mar 03 '24 22:03 lukemurraynz

Hi!

Correct me if I'm wrong, but isn't the Partner Admin Link/partnerId that you link to, a feature of the user account, and not a feature of the subscription? So you wouldn't normally set it for each subscription? Unless we're talking about partnerId for DPOR or what's it called, that I've seen only on EA? Ref. what is discussed here: https://www.reddit.com/r/AZURE/comments/z8e07j/comment/j5pcaze/

mysteq avatar Mar 11 '24 22:03 mysteq

Hi!

Correct me if I'm wrong, but isn't the Partner Admin Link/partnerId that you link to, a feature of the account, and not a feature of the subscription? So you wouldn't normally set it for each subscription? Unless we're talking about partnerId for DPOR or what's it called, that I've seen only on EA? Ref. what is discussed here: https://www.reddit.com/r/AZURE/comments/z8e07j/comment/j5pcaze/

You can do it at tenant and as subscription, ie different partners could manage different subscriptions.

lukemurraynz avatar Mar 12 '24 02:03 lukemurraynz

Would you be able to do a proof of concept using AzAPI based on the subscription resource id that is generated by this module?

Put the PoC resource in the root module for now.

Once we have a confirmed working resource block, I'm happy to add to the subscription module.

matt-FFFFFF avatar Mar 16 '24 12:03 matt-FFFFFF

Would you be able to do a proof of concept using AzAPI based on the subscription resource id that is generated by this module?

Put the PoC resource in the root module for now.

Once we have a confirmed working resource block, I'm happy to add to the subscription module.

Sounds good; give me a few days - I will be flying back to NZ tomorrow.

lukemurraynz avatar Mar 16 '24 15:03 lukemurraynz