static-web-apps-cli icon indicating copy to clipboard operation
static-web-apps-cli copied to clipboard

Auth UI incorrectly show `AAD` instead of new term `Microsoft Entra ID`

Open diberry opened this issue 1 year ago • 3 comments

image

This React app front-end shows how I fixed this issue for the UI. https://github.com/Azure-Samples/azure-typescript-e2e-apps/pull/69

@adrianhall @BandaruDheeraj @craigshoemaker

diberry avatar Jun 16 '24 14:06 diberry

This is actually correct, as the identity provider name in the spec and api is azureActiveDirectory, which means aad is the correct abbreviation. This issue can be closed or set on halt until the official json schema was updated.

itpropro avatar Jun 28 '24 22:06 itpropro

I'm working on a fix for this issue. Quick question: Should we:

  1. Just update the display name in the UI from 'AAD' to 'Microsoft Entra ID' (keeping 'aad' as the underlying value)
  2. Change the underlying provider value throughout the codebase from 'aad' to something like 'microsoft-entra-id'

Option 1 is simpler and maintains backward compatibility. Option 2 is more correct but would be a breaking change.

Which approach would you prefer?

keith-oak avatar Jun 25 '25 00:06 keith-oak

I'm working on a fix for this issue. Quick question: Should we:

1. Just update the display name in the UI from 'AAD' to 'Microsoft Entra ID' (keeping 'aad' as the underlying value)

2. Change the underlying provider value throughout the codebase from 'aad' to something like 'microsoft-entra-id'

Option 1 is simpler and maintains backward compatibility. Option 2 is more correct but would be a breaking change.

Which approach would you prefer?

I think option 1 is fine as long as the underlying token fields etc. match 1:1 the production ones in Azure. The main concern is that there is a deviation from how things are implemented in Azure.

itpropro avatar Jun 25 '25 14:06 itpropro